From owner-freebsd-current Fri Aug 20 12: 1:20 1999 Delivered-To: freebsd-current@freebsd.org Received: from dt010nb9.san.rr.com (dt010nb9.san.rr.com [204.210.12.185]) by hub.freebsd.org (Postfix) with ESMTP id 06AB6153A7 for ; Fri, 20 Aug 1999 12:01:05 -0700 (PDT) (envelope-from Doug@gorean.org) Received: from localhost (doug@localhost) by dt010nb9.san.rr.com (8.9.3/8.8.8) with ESMTP id LAA68762; Fri, 20 Aug 1999 11:59:05 -0700 (PDT) (envelope-from Doug@gorean.org) Date: Fri, 20 Aug 1999 11:59:05 -0700 (PDT) From: Doug X-Sender: doug@dt010nb9.san.rr.com To: Sheldon Hearn Cc: current@freebsd.org Subject: Re: REQ: Test /etc/rc clean-up In-Reply-To: <21889.935137150@axl.noc.iafrica.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 20 Aug 1999, Sheldon Hearn wrote: > > Hi folks, > > I have a diff for src/etc/rc that I'd like to have had used on a few > machines before I commit it. I'm pretty sure I haven't made any mistakes > with my changes, but you can never be too careful, right? > > The diff homogenizes the manner in which variables are tested and is > more careful about using variables in a manner that avoids potential > problems that are unlikely to occur. I see it as a mostly cosmetic, but > healthy change. I agree that there are a lot of things in the rc.* scripts that need cleaning, and making the variable treatment safe and consistent is a good start. However I'd REALLY like to emphasize again that if we're going to do this the proper fix is to use case wherever possible. There are numerous reasons for this, not the least of which are making the variable case insensitive (and therefore more user friendly) and that case is a builtin. For example: > -if [ X$start_vinum = XYES ]; then case "${start_vinum}" in [Yy][Ee][Ss] ) do whatever ;; esac I have offered several times to do the work if it has a chance of being committed, that offer is still good. Either way I think that the cleanup effort is a good thing. Doug To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message