From owner-p4-projects@FreeBSD.ORG  Tue Aug 19 22:38:25 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C54EB1065673; Tue, 19 Aug 2008 22:38:25 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88EB31065672
	for <perforce@freebsd.org>; Tue, 19 Aug 2008 22:38:25 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A6ED8FC14
	for <perforce@freebsd.org>; Tue, 19 Aug 2008 22:38:25 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7JMcPCu021368
	for <perforce@freebsd.org>; Tue, 19 Aug 2008 22:38:25 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7JMcPJU021366
	for perforce@freebsd.org; Tue, 19 Aug 2008 22:38:25 GMT
	(envelope-from jb@freebsd.org)
Date: Tue, 19 Aug 2008 22:38:25 GMT
Message-Id: <200808192238.m7JMcPJU021366@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 147847 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Aug 2008 22:38:26 -0000

http://perforce.freebsd.org/chv.cgi?CH=147847

Change 147847 by jb@freebsd3 on 2008/08/19 22:38:19

	Add some probes for successful stat()s without having to trigger on
	all stat()s because a lot are for files that don't exist and we 
	contribute to global warming if we trigger on those.

Affected files ...

.. //depot/projects/dtrace/src/sys/kern/vfs_syscalls.c#26 edit

Differences ...

==== //depot/projects/dtrace/src/sys/kern/vfs_syscalls.c#26 (text+ko) ====

@@ -90,6 +90,7 @@
 SDT_PROBE_ARGTYPE(vfs, , stat, mode, 1, "int");
 SDT_PROBE_DEFINE(vfs, , stat, reg);
 SDT_PROBE_ARGTYPE(vfs, , stat, reg, 0, "char *");
+SDT_PROBE_ARGTYPE(vfs, , stat, reg, 1, "int");
 
 static int chroot_refuse_vdir_fds(struct filedesc *fdp);
 static int getutimes(const struct timeval *, enum uio_seg, struct timespec *);
@@ -2341,6 +2342,11 @@
 		return (error);
 	vfslocked = NDHASGIANT(&nd);
 	error = vn_stat(nd.ni_vp, &sb, td->td_ucred, NOCRED, td);
+	if (!error) {
+		SDT_PROBE(vfs, , stat, mode, path, sb.st_mode, 0, 0, 0);
+		if (S_ISREG(sb.st_mode))
+			SDT_PROBE(vfs, , stat, reg, path, pathseg, 0, 0, 0);
+	}
 	NDFREE(&nd, NDF_ONLY_PNBUF);
 	vput(nd.ni_vp);
 	VFS_UNLOCK_GIANT(vfslocked);
@@ -2353,10 +2359,6 @@
 	if (KTRPOINT(td, KTR_STRUCT))
 		ktrstat(&sb);
 #endif
-	SDT_PROBE(vfs, , stat, mode, path, sb.st_mode, 0, 0, 0);
-	if (S_ISREG(sb.st_mode)) {
-		SDT_PROBE(vfs, , stat, reg, path, 0, 0, 0, 0);
-	}
 	return (0);
 }