From owner-svn-src-all@FreeBSD.ORG Tue Jun 21 06:04:45 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8077C106564A; Tue, 21 Jun 2011 06:04:45 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 2AFAD8FC13; Tue, 21 Jun 2011 06:04:45 +0000 (UTC) Received: from delta.delphij.net (c-76-102-50-245.hsd1.ca.comcast.net [76.102.50.245]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id D14AEF2E4; Mon, 20 Jun 2011 23:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1308636285; bh=qUyT6GK/QBoxk9q3wl9v1gpVh8j/16mBRAKz9CfN/KI=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=NfL5o4iPTD3wQjlNFztP0onIbld4tZQWUBFbj6fdGpQfeMBxr8fvj7japZL747eJj HJ11RM8PYhT4Kv3oscKtJYbEcUpND5UNfrGMD/FhRtywOI5VDH8tyLJ2NkM9RqnknK PihlmtFuP43XqNrwTD9YZzx2VORWeoXxMyJcVDcI= Message-ID: <4E00347A.80407@delphij.net> Date: Mon, 20 Jun 2011 23:04:42 -0700 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <201106210446.p5L4k0IZ080002@svn.freebsd.org> <4E00263C.4040802@yandex.ru> In-Reply-To: <4E00263C.4040802@yandex.ru> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI Subject: Re: svn commit: r223356 - head/sbin/geom/class/part X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 06:04:45 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/20/11 22:03, Andrey V. Elsukov wrote: > On 21.06.2011 8:46, Xin LI wrote: >> Author: delphij >> Date: Tue Jun 21 04:46:00 2011 >> New Revision: 223356 >> URL: http://svn.freebsd.org/changeset/base/223356 >> >> Log: >> Mod the offset padding by alignment. Without this change we may >> pad too much when underlying GEOM object have a zero stripesize. > > No. In any way offset value could not be greater than mediasize. I don't think this changeset do anything with mediasize? > And it do nothing when alignment value is 1. No, an alignment value of 1 makes offset = 0, which is the intended behavior. Or did I misunderstood the code? Thanks in advance! >> MFC after: 1 month > > I did not MFC'd these changes yet. > >> Modified: >> head/sbin/geom/class/part/geom_part.c >> >> Modified: head/sbin/geom/class/part/geom_part.c >> ============================================================================== >> --- head/sbin/geom/class/part/geom_part.c Tue Jun 21 04:06:39 2011 (r223355) >> +++ head/sbin/geom/class/part/geom_part.c Tue Jun 21 04:46:00 2011 (r223356) >> @@ -362,7 +362,7 @@ gpart_autofill_resize(struct gctl_req *r >> goto done; >> } >> >> - offset = pp->lg_stripeoffset / pp->lg_sectorsize; >> + offset = (pp->lg_stripeoffset / pp->lg_sectorsize) % alignment; >> last = (off_t)strtoimax(find_geomcfg(gp, "last"), NULL, 0); >> LIST_FOREACH(pp, &gp->lg_provider, lg_provider) { >> s = find_provcfg(pp, "index"); >> @@ -497,7 +497,7 @@ gpart_autofill(struct gctl_req *req) >> alignment = len; >> >> /* Adjust parameters to stripeoffset */ >> - offset = pp->lg_stripeoffset / pp->lg_sectorsize; >> + offset = (pp->lg_stripeoffset / pp->lg_sectorsize) % alignment; >> start = ALIGNUP(start + offset, alignment); >> if (size > alignment) >> size = ALIGNDOWN(size, alignment); >> >> > > - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJOADR6AAoJEATO+BI/yjfBG5gH/2AFDv/cyvUXM16C5GBKjj8m XOqqRziAPz8VsICXjFLBdx0wxguYAB7Dr4U8krUgH0rOMIUXuew6lNmjQxfW2TQd 66o8XMTe9WdV28SZcJDJWpU5vAD2lQcGs88AjJt4fbtndHte3XN1kjBdZ6DpmMLw gdbn1iU836DFTE4kMdOhNb+h4RRbGNNx8QJ0jJO0RNrIUMy+w/dbgGUTqjYm6hTj vbZlA41QxSEx/cTDH7puje3/E9j9cIaOo3sCNpk1YrnVF7Syzn7arBruCmpDEVsN NIGVbD+WMvS4VxLK1Vwb6C1G6nYmf74fHDmkcwV4sg5iUw8V2SS6AO73ml9I/7U= =nfFW -----END PGP SIGNATURE-----