From owner-svn-src-all@FreeBSD.ORG Tue Apr 16 22:44:01 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E9FFC6A6; Tue, 16 Apr 2013 22:44:01 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx1.freebsd.org (Postfix) with ESMTP id 72BB91CAE; Tue, 16 Apr 2013 22:44:00 +0000 (UTC) Received: by mail-ve0-f169.google.com with SMTP id d10so948174vea.0 for ; Tue, 16 Apr 2013 15:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=entza7VvV6xA/2cRae4rz7UqexxuZYr/C29yW0+lQLA=; b=dKRTUlK3um+EgqNK6Y8jIZoXBZQX+GThjHsaXFitHlB+mNoCq1QGR+3R4Mu3dmep2m z6psFlUzP0jQAPlAIKgpK5LnUb+YyQP06Z3C8KO9jyS7RRA8Rrtwu5M7dJFHBlF2PIKK pgwRtuQM2ioZr06sWjUQF+uRheyaEd15eg8bYOFYiSdYcbgDiOAGotkbVs4q73if0c9W 9dHGfO1UigIbSxqmRfUmzDpOqk77ciMn9NIrGcCa+Iy3u4Ht7Pg2cnjH+J4lMZITXpJZ EMRY+2RIrG1hvtQDmdnRqInn1xQq3aYTcOn2b1Xe4IckZO9WxxIvDWZjV1hPP3KRLxim 97wg== X-Received: by 10.52.99.67 with SMTP id eo3mr2676430vdb.21.1366152234115; Tue, 16 Apr 2013 15:43:54 -0700 (PDT) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.58.34.162 with HTTP; Tue, 16 Apr 2013 15:43:13 -0700 (PDT) In-Reply-To: References: <201304161958.r3GJwO2h084815@svn.freebsd.org> From: Ivan Voras Date: Wed, 17 Apr 2013 00:43:13 +0200 X-Google-Sender-Auth: BlLAcfVy7RhbSoA8TUbR7ehZT8E Message-ID: Subject: Re: svn commit: r249564 - head/sys/geom/label To: Dimitry Andric Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2013 22:44:02 -0000 On 16 April 2013 22:01, Dimitry Andric wrote: > On Apr 16, 2013, at 21:58, Ivan Voras wrote: >> Author: ivoras >> Date: Tue Apr 16 19:58:24 2013 >> New Revision: 249564 >> URL: http://svnweb.freebsd.org/changeset/base/249564 >> >> Log: >> Fix the buffer-overflow-fixing fixes. > ... >> + /* >> + * We can safely ignore the result of strncpy; the label will >> + * simply be truncated, which at most is only annoying. >> + */ >> + (void)snprintf(label, size, "%s-%s", cls->name, ident); > > s/strncpy/snprintf/ ? :-) The typo fairy is strong this day :) Thanks!