From owner-cvs-all@FreeBSD.ORG Thu Nov 15 20:08:17 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E00D16A41A; Thu, 15 Nov 2007 20:08:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 2B9FE13C4DD; Thu, 15 Nov 2007 20:08:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id lAFK8Ain027094; Thu, 15 Nov 2007 13:08:10 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <473CA723.9000409@samsco.org> Date: Thu, 15 Nov 2007 13:08:03 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Robert Watson References: <200711151416.lAFEGKJ6059040@repoman.freebsd.org> <473C865D.8070809@elischer.org> <20071115181401.GA17094@troutmask.apl.washington.edu> <473C901F.1080906@elischer.org> <20071115194710.L82897@fledge.watson.org> In-Reply-To: <20071115194710.L82897@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Thu, 15 Nov 2007 13:08:10 -0700 (MST) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Gleb Smirnoff , Julian Elischer , Steve Kargl Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2007 20:08:17 -0000 Robert Watson wrote: > > On Thu, 15 Nov 2007, Julian Elischer wrote: > >>>> "no matter how small the change, use diff + patch to move it across." >>> >>> After applying the patch on your commit machine, is it too difficult >>> to actually retest before committing? This would catch the broken >>> commit before it becomes a Tinderbox issue. >>> >>> Seems to be a QA problem on your part. >> >> yes.. but I can't do a compile from my mac. (my commit machine). The >> answer is to be rigorous about how I move the patch from the build >> machine to the commit machine. >> >> This is a temporary situation. new infrastructure will let me commit >> from my build machine again. > > I find having a copy of Parallels (or VMWare) around very useful for > precisely this situation -- it means that even when I have only the Mac > around I can easily do a local test build. The various VM packages > certainly have their limitations, but they're far better than nothing. > And to be fair, there are habitual build breakers and there are non-habitual build breakers. Julian, IMHO, falls mostly into the latter category, yet I see people focus on him disproportionally. Funny. Kinda. Not. Scott