From owner-cvs-ports@FreeBSD.ORG Thu Sep 22 18:53:15 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C650E106564A; Thu, 22 Sep 2011 18:53:15 +0000 (UTC) (envelope-from ehaupt@critical.ch) Received: from mx.critical.ch (cl-8.zrh-02.ch.sixxs.net [IPv6:2001:1620:f00:7::2]) by mx1.freebsd.org (Postfix) with ESMTP id 3DA638FC17; Thu, 22 Sep 2011 18:53:15 +0000 (UTC) Received: from [10.31.75.113] (gprs53.swisscom-mobile.ch [193.247.250.53]) (authenticated bits=0) by mx.critical.ch (8.14.4/8.14.4/critical-1.0) with ESMTP id p8MIr4bd050095; Thu, 22 Sep 2011 20:53:08 +0200 (CEST) (envelope-from ehaupt@critical.ch) References: <201103100949.p2A9nOO8057627@repoman.freebsd.org> <20110919234126.GA82010@server.vk2pj.dyndns.org> <20110921115818.2878356b.ehaupt@FreeBSD.org> <4E7A23D3.5070509@FreeBSD.org> <20110921210838.893ad8f0.ehaupt@FreeBSD.org> <4E7A437A.5030401@FreeBSD.org> In-Reply-To: <4E7A437A.5030401@FreeBSD.org> Mime-Version: 1.0 (iPhone Mail 8J2) Content-Type: text/plain; charset=us-ascii Message-Id: <21BC4480-6954-47F2-A5DA-F6F920CF9637@critical.ch> Content-Transfer-Encoding: 7bit X-Mailer: iPhone Mail (8J2) From: Emanuel Haupt Date: Thu, 22 Sep 2011 20:52:31 +0200 To: Doug Barton Cc: "cvs-all@FreeBSD.org" , "cvs-ports@FreeBSD.org" , Peter Jeremy , Emanuel Haupt , "ports-committers@FreeBSD.org" Subject: Re: cvs commit: ports/x11/xterm Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2011 18:53:15 -0000 On 21.09.2011, at 22:05, Doug Barton wrote: > On 09/21/2011 12:08, Emanuel Haupt wrote: >> Doug Barton wrote: >>> On 09/21/2011 02:58, Emanuel Haupt wrote: >>>> Peter Jeremy wrote: >>> >>>>> This is a bit belated but why does xterm need a hard dependency >>>>> on gnome? Could you please look at making this optional so that >>>>> those of us who don't run bloatware can turn it off. >>>> >>>> Good point. I've just committed a patch that makes the installation >>>> of desktop entries conditional. >>> >>> What isn't clear to me is why the installation of the desktop entry >>> depends on gnome at all. Why not just install the file? I ask because >>> (at least) xfce also uses the desktop entries, so having them is >>> useful for non-gnome cases as well. >> >> From what I understand "desktopfileutils" needs to be set in (USE| >> WANT)_GNOME if there are *.desktop files installed. This is where some >> gnome dependencies are pulled in. > > Yes, I understand that this is your understanding, otherwise you > wouldn't have done it that way. :) I am attempting to challenge that > understanding. IOW, can the installation of the desktop file be split > out from the gnome desktopfileutils part? > > The attached works for the non-gnome case, and the xterm.desktop file > appears as expected for xfce. Looks good. Feel free to commit, I am currently afk. Emanuel > > > Doug > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > >