From owner-freebsd-current@FreeBSD.ORG Tue Dec 23 17:31:21 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B92E16A4CE; Tue, 23 Dec 2003 17:31:21 -0800 (PST) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D0BA43D2D; Tue, 23 Dec 2003 17:31:16 -0800 (PST) (envelope-from rodrigc@crodrigues.org) Received: from h00609772adf0.ne.client2.attbi.com ([66.31.45.197]) by comcast.net (rwcrmhc12) with ESMTP id <20031224013115014000t1eue>; Wed, 24 Dec 2003 01:31:15 +0000 Received: from h00609772adf0.ne.client2.attbi.com (localhost.crodrigues.org [127.0.0.1])hBO1VNZ3078672; Tue, 23 Dec 2003 20:31:23 -0500 (EST) (envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com) Received: (from rodrigc@localhost)hBO1VMri078671; Tue, 23 Dec 2003 20:31:22 -0500 (EST) (envelope-from rodrigc) Date: Tue, 23 Dec 2003 20:31:22 -0500 From: Craig Rodrigues To: Ryan Sommers Message-ID: <20031224013122.GA78647@crodrigues.org> References: <20031224005024.GA78326@crodrigues.org> <1072228313.702.3.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1072228313.702.3.camel@localhost> User-Agent: Mutt/1.4.1i cc: freebsd-current@freebsd.org cc: harti@freebsd.org cc: peter@freebsd.org Subject: Re: Error building if_fatm.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2003 01:31:21 -0000 On Tue, Dec 23, 2003 at 07:11:53PM -0600, Ryan Sommers wrote: > On Tue, 2003-12-23 at 18:50, Craig Rodrigues wrote: > > /usr/src/sys/dev/fatm/if_fatm.c: In function `fatm_open_vcc': > > /usr/src/sys/dev/fatm/if_fatm.c:2285: warning: comparison between pointer and integer > > *** Error code 1 > > This is just a warning, it isn't what is causing the error. It looks > like you are compiling with the -j option and this will sometimes hide > the real cause of the failure. Try compiling without -j and see what the > error condition is it is hitting. > > PS As for the redefinition of NULL you could change it to that, or just > cast NULL to an int. Wrong. I am not compiling with -j. I am simply doing: make buildkernel KERNCONF=MYKERNEL1 If you look at my previous message, you will see that -Werror is being passed to the compiler...this is causing the warning to be flagged as an error. (NOTE: My /etc/make.conf file is empty, so this behavior is obtained from the default FreeBSD kernel makefile rules). I think my patch to if_fatm.c fixes things (since it unbreaks things for me) but I just wanted to clarify things on this mailing list. I think this problem emerged due to the following change to /usr/src/sys/sys/_null.h : ========================================================================== Revision 1.3 / (download) - annotate - [select for diffs], Tue Dec 23 02:34:25 2003 UTC (22 hours, 54 minutes ago) by peter Branch: MAIN Changes since 1.2: +4 -0 lines Diff to previous 1.2 (colored) Don peril sensitive sunglasses and set NULL to an actual pointer type, but *only* for the kernel. We can do this because the kernel is not a standard C application environment. This would have stopped the recent mtx_* arg NULL/MTX_DEF mixups from going unnoticed for so long. ========================================================================== -- Craig Rodrigues http://crodrigues.org rodrigc@crodrigues.org