From owner-cvs-all  Wed Feb 14 14:59:21 2001
Delivered-To: cvs-all@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id BA23637B4EC; Wed, 14 Feb 2001 14:59:12 -0800 (PST)
Received: (from ache@localhost)
	by nagual.pp.ru (8.11.2/8.11.2) id f1EMx2U76855;
	Thu, 15 Feb 2001 01:59:02 +0300 (MSK)
	(envelope-from ache)
Date: Thu, 15 Feb 2001 01:59:01 +0300
From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
To: Alexey Zelkin <phantom@cris.crimea.ua>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/locale ldpart.c ldpart.h
Message-ID: <20010215015901.A76630@nagual.pp.ru>
References: <000e01c09686$8b6e0040$ce8f6ed4@spider.cris.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <000e01c09686$8b6e0040$ce8f6ed4@spider.cris.net>; from phantom@cris.crimea.ua on Wed, Feb 14, 2001 at 04:02:53PM +0300
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wed, Feb 14, 2001 at 16:02:53 +0300, Alexey Zelkin wrote:
> It's not such simple as you propose. First of all, num_lines check should be
> located
> before code which fills internal structures (i.e. before set_from_buf()
> call).

Yes, you need to read whole file first then parse it to struct according
to calculated num_lines, then free temp buf.

> IMHO, both variants are just overheads and includes a lot of unneeded code
> to libc. I think we don't

There is no overheads in that, just separation.

> need such changes until we really need them. BTW, I don't propose to add
> __part_load_locale()
> calls to libc anymore because it's already used in all places there I
> proposed to use it. Also __part_load_locale() is libc internal function and
> will not be used in any external programs.
> Logicaly next step is optimization and not universalization, isn't it ?

Currently yes, but in my memory LC_TIME locale grows several times, so
planned again too. At this moment I am unhappy with our %Ef solution
because it is non-standard. I am unhappy with our %c solution too. I think
it should be rewritted somehow when standard bodies got acceptable
workarounds.

-- 
Andrey A. Chernov
http://ache.pp.ru/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message