From owner-freebsd-bugs@FreeBSD.ORG  Sun May  1 13:10:05 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C170916A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  1 May 2005 13:10:05 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9D60343D45
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  1 May 2005 13:10:05 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j41DA5uC021795
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 1 May 2005 13:10:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j41DA59P021794;
	Sun, 1 May 2005 13:10:05 GMT
	(envelope-from gnats)
Date: Sun, 1 May 2005 13:10:05 GMT
Message-Id: <200505011310.j41DA59P021794@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Adam Kropelin" <akropel1@rochester.rr.com>
Subject: Re: kern/80383: [PATCH] Add quirk for uhid to ignore certain
	usbdevices (blacklist)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Adam Kropelin <akropel1@rochester.rr.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 May 2005 13:10:05 -0000

The following reply was made to PR kern/80383; it has been noted by GNATS.

From: "Adam Kropelin" <akropel1@rochester.rr.com>
To: "Thierry Thomas" <thierry@freebsd.org>,
	"Lonnie Mendez" <lmendez19@austin.rr.com>
Cc: <FreeBSD-gnats-submit@freebsd.org>, <freebsd-usb@freebsd.org>
Subject: Re: kern/80383: [PATCH] Add quirk for uhid to ignore certain usbdevices (blacklist)
Date: Sun, 1 May 2005 09:08:12 -0400

 Thierry Thomas wrote:
 >> Le Mer 27 avr 05 à  7:55:31 +0200, Lonnie Mendez
 >> <lmendez19@austin.rr.com> écrivait :
 >>>
 >>>> Number:         80383
 >>>> Category:       kern
 >>>> Synopsis:       [PATCH] Add quirk for uhid to ignore certain usb
 >>>> devices (blacklist)
 >>
 >>>> Description:
 >>>
 >>> This patch allows uhid to leave alone devices that identify
 >>> themselves as hid based, but are indeed
 >>> used via another interface.  This is very simliar in concept to the
 >>> hid blacklist table found in hid-core.c in the linux kernel.
 >>
 >> Fine! I also need this to use the new MGE UPS devices (with nut,
 >> libusb and the newhidups driver). I have applied the submitted patch
 >> on a
 >> 5.4-STABLE, and it's OK.
 >>
 >> To add the MGE UPS devices, I need the attached patches.
 
 Just to nitpick a little...
 
 > +product MGE UPS1  0x0001 MGEUPS newhidups 1
 > +product MGE UPS2  0xffff MGEUPS newhidups 2
 
 I'm not sure it's appropriate in this context to refer to a userspace 
 program like "newhidups". I think this field is really meant to be a textual 
 name for the product being identified. Based on the other entries in the 
 file, something like a model name or generc description may be more 
 appropriate.
 
 --Adam