From owner-cvs-all Fri Dec 4 11:13:24 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA10140 for cvs-all-outgoing; Fri, 4 Dec 1998 11:13:24 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from sicily.odyssey.cs.cmu.edu (SICILY.ODYSSEY.CS.CMU.EDU [128.2.185.138]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id LAA10111; Fri, 4 Dec 1998 11:13:06 -0800 (PST) (envelope-from rvb+@sicily.odyssey.cs.cmu.edu) To: Garrett Wollman Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys bus.h bus_private.h conf.h devicestat.h module.h src/sys/kern bus_if.m device_if.m kern_conf.c subr_bus.c subr_devstat.c References: <199811142158.NAA22480@freefall.freebsd.org> From: "Robert V. Baron" Date: 04 Dec 1998 14:12:29 -0500 In-Reply-To: Garrett Wollman's message of Sat, 14 Nov 1998 13:58:52 -0800 (PST) Message-ID: Lines: 29 X-Mailer: Gnus v5.4.46/Emacs 19.34 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Garrett Wollman writes: > wollman 1998/11/14 13:58:52 PST > > Modified files: > sys/sys bus.h bus_private.h conf.h devicestat.h > module.h > sys/kern bus_if.m device_if.m kern_conf.c > subr_bus.c subr_devstat.c > Log: > My changes to the new device interface: I guess I didn't build a kernel in a while so I just got nailed by this: subr_rman.c includes sys/bus.h. But bus.h could not find /* * Some common device interfaces. */ #include "device_if.h" #include "bus_if.h" These actually get built later in a kernel build, so this could be solved by a few dependency lines in the Makefile. (I don't make depend in my kernel build area. (I just rm -rf)) But I would like to argue that is is incorrect for any exported file, sys/bus.h in this case, to include files that are not permanent. What happens when sys/bus.h makes it into /usr/include/sys and some one includes it in a program and ... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message