From owner-cvs-all Thu Dec 31 00:00:55 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA05590 for cvs-all-outgoing; Thu, 31 Dec 1998 00:00:55 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA05585 for ; Thu, 31 Dec 1998 00:00:51 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (peter@localhost [127.0.0.1]) by spinner.netplex.com.au (8.9.1/8.9.1/Netplex) with ESMTP id QAA90152; Thu, 31 Dec 1998 16:00:11 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199812310800.QAA90152@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Luigi Rizzo cc: committers@FreeBSD.ORG Subject: Re: ES1370 audio driver -- where do i put it ? In-reply-to: Your message of "Thu, 31 Dec 1998 06:43:20 +0100." <199812310543.GAA19458@labinfo.iet.unipi.it> Date: Thu, 31 Dec 1998 16:00:06 +0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Luigi Rizzo wrote: > The recent commits to the pcm driver were meant to integrate Joackim's > driver for ES1370-based cards. > > Being a PCI card i'd put the relevant files (es1370.c and > es1370_reg.h) in /sys/pci; however, at the moment this is a > i386-specific piece of code (although it used absolutely no ISA > functionality so chances are that it works with minor fixes on the > Alpha as well). So, is the location ok, or perhaps it should go in > /sys/i386/isa/snd with the other "pcm" files ? Well, on the offchance that the sound code that is currently in the isa directories becomes portable to ISA busses in general, having the PCI driver already in sys/pci would mean one less file to copy or reorganize. Also, there is a precedent: sys/i386/isa/if_ed* and sys/pci/if_ed_p.c (the pci glue). So, stick it in sys/pci unless there's absolutely zero chance that it'll ever be used on something other than i386. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message