From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 24 12:50:10 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2CA8016A521 for ; Wed, 24 Oct 2007 12:50:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2604413C4C2 for ; Wed, 24 Oct 2007 12:50:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9OCo9Oj045483 for ; Wed, 24 Oct 2007 12:50:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9OCo9lF045482; Wed, 24 Oct 2007 12:50:09 GMT (envelope-from gnats) Date: Wed, 24 Oct 2007 12:50:09 GMT Message-Id: <200710241250.l9OCo9lF045482@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Pietro Cerutti Cc: Subject: Re: ports/117319: [patch] games/xlogical bad C++ code w/ gcc4.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pietro Cerutti List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2007 12:50:10 -0000 The following reply was made to PR ports/117319; it has been noted by GNATS. From: Pietro Cerutti To: Sergio Mangialardi , bug-followup@FreeBSD.org, gahr@gahr.ch Cc: Subject: Re: ports/117319: [patch] games/xlogical bad C++ code w/ gcc4.2 Date: Wed, 24 Oct 2007 14:42:35 +0200 Sergio Mangialardi wrote: > Pietro Cerutti wrote: >> >> You are right. Please comment on this one: >> >> --- gamelogic.cpp.orig 2007-10-19 17:52:30.000000000 +0200 >> +++ gamelogic.cpp 2007-10-19 17:53:15.000000000 +0200 >> @@ -154,7 +154,7 @@ >> levelFile = NULL; >> } >> >> - currentMap = NULL; >> + currentMap = gameLevels.end( ); > This is the correct initialization of currentMap, because it is > independent of the underlying implementation of the iterator. > > Sergio. Thanks. I think the patch is ready to be committed. -- Pietro Cerutti PGP Public Key: http://gahr.ch/pgp