From owner-svn-src-all@FreeBSD.ORG Mon Feb 6 16:09:11 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D555F1065672; Mon, 6 Feb 2012 16:09:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id AB6268FC12; Mon, 6 Feb 2012 16:09:11 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 6592646B23; Mon, 6 Feb 2012 11:09:11 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id CBD2FB925; Mon, 6 Feb 2012 11:09:10 -0500 (EST) From: John Baldwin To: Nathan Whitehorn Date: Mon, 6 Feb 2012 11:06:59 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <201202051654.q15GsQcc092137@svn.freebsd.org> <201202060753.43627.jhb@freebsd.org> <4F2FF486.5090507@freebsd.org> In-Reply-To: <4F2FF486.5090507@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201202061106.59098.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 06 Feb 2012 11:09:10 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r231026 - head/sys/powerpc/ofw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 16:09:11 -0000 On Monday, February 06, 2012 10:40:54 am Nathan Whitehorn wrote: > On 02/06/12 06:53, John Baldwin wrote: > > On Sunday, February 05, 2012 11:54:26 am Nathan Whitehorn wrote: > >> Author: nwhitehorn > >> Date: Sun Feb 5 16:54:26 2012 > >> New Revision: 231026 > >> URL: http://svn.freebsd.org/changeset/base/231026 > >> > >> Log: > >> Make sure to remap adjusted resources. > > Hmm, I had considered remapping adjusted resources an invalid operation (i.e. > > should fail with EINVAL). I believe that the NEW_PCIB code should only apply > > this API to resources backing the resource windows in PCI-PCI bridges and that > > those resources should never have RF_ACTIVE set. Are you seeing calls of it > > for active resources? > > > No, I was just trying to be safe here, since it wasn't clear that that > was invalid. I'm happy to replace the contents of the if with return > EINVAL or something. Yeah, I would do that, perhaps with a KASSERT() as well so it panics in HEAD. -- John Baldwin