From owner-svn-ports-head@FreeBSD.ORG Tue Jan 8 07:59:08 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 62A17EE3; Tue, 8 Jan 2013 07:59:08 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by mx1.freebsd.org (Postfix) with ESMTP id 6BC3189; Tue, 8 Jan 2013 07:59:06 +0000 (UTC) Received: by mail-ea0-f172.google.com with SMTP id a1so49174eaa.31 for ; Mon, 07 Jan 2013 23:59:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=ukT0PTt5x3uXqU+z3KsIlvuXcZ8VeCh8+SWmu0YlTD8=; b=GSytHivLnHKP53z6yYzu1+UfJKTII2pBntBfj95Li0EKznkTSwNWCwOFtMNarbjc0T +jIL54AvrnnqfSUXFwRSTRR0kdibaVwp/XmEOgkVTo6SnpL/TXMxSxvmDI/9TNW8jk56 6OnWa1cU5vV+iz5/YgJzb+LWIBr4v0oVYFjKddiqs929E1Vikxcuwghcx2vgCVE+wTqF qEn+o2DVgpU6XJC8TBMnqXh8DjP3MtKyccDpyK1p3De4MidDjz4jFUmtIQyKINOgqwJ/ I0Kf9y3OX9m8DAYCTDeJU31/nBV6dgb74/nmJlbJL89F9pav2ybpNvF8QEwzwWyktXRf G2XA== X-Received: by 10.14.205.198 with SMTP id j46mr172761763eeo.27.1357631618253; Mon, 07 Jan 2013 23:53:38 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id f49sm134160339eep.12.2013.01.07.23.53.37 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Jan 2013 23:53:37 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 8 Jan 2013 08:53:35 +0100 From: Baptiste Daroussin To: Glen Barber Subject: Re: svn commit: r310063 - in head: . sysutils/cfengine Message-ID: <20130108075335.GQ85686@ithaqua.etoilebsd.net> References: <201301080433.r084X9IR015052@svn.freebsd.org> <20130108071049.GP85686@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Tcb1KvpfnM4LxW2s" Content-Disposition: inline In-Reply-To: <20130108071049.GP85686@ithaqua.etoilebsd.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2013 07:59:08 -0000 --Tcb1KvpfnM4LxW2s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 08, 2013 at 08:10:49AM +0100, Baptiste Daroussin wrote: > On Tue, Jan 08, 2013 at 04:33:09AM +0000, Glen Barber wrote: > > Author: gjb > > Date: Tue Jan 8 04:33:08 2013 > > New Revision: 310063 > > URL: http://svnweb.freebsd.org/changeset/ports/310063 > >=20 > > Log: > > Implement the concept of a "master" port for the set of > > sysutils/cfengine* ports. > > =20 > > The idea here is two-fold: > > =20 > > 1.) Users should not need to ever change port origins > > for a default software version bump; > > 2.) Users should expect to exist an unversioned port > > directory to reflect the latest major version (and > > they should be correct in this expectation). > > =20 > > With this change, users can install the sysutils/cfengine > > port, and by default track the latest major version of the > > software. Subsequent version releases, for example the 3.5 > > branch, will not require any interaction from user side. > > =20 > > Additionally, users can stay on a certain branch release by > > adding, in this case, CFENGINE_VERSION version to make.conf > > or specifying the branch during build time with: > > =20 > > # make CFENGINE_VERSION=3DNN > > =20 > > The list of available CFENGINE_VERSION values are listed > > with: > > =20 > > # make -V VERSIONS > > =20 > > Discussed with: cy > >=20 >=20 > Nice! In my opinion this should be followed by all/most? ports with multi > version in the ports tree, this will fix also fix tracking in binary work= major > upgrades (aka change of default version) with no manuall intervention. >=20 > regards, > Bapt While I do like this idea, the implementation is broken: index and package building is broken now let me show you why: # cd /usr/ports/sysutils/cfengine # make -VPKGNAME -VLATEST_LINK cfengine-3.4.1 cfengine34 # cd /usr/ports/sysutils/cfengine34 # make -VPKGNAME -VLATEST_LINK cfengine-3.4.1 cfengine34 and it is forbidden to have 2 exactly same LATEST_LINK and 2 exactly same PKGNAME imho the right thing would be in cfengine34 to: define LATEST_LINK only if !defined(MASTERDIR) and to add PKGNAMESUFFIX=3D34 if !defined(MASTERDIR) regards, Bapt --Tcb1KvpfnM4LxW2s Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDr0H8ACgkQ8kTtMUmk6Ew3tgCfbj6uoIxXf77FgE+UFBeAMUHh o10AoL4SMeImnOUHMjsj6EOA5b4EWe2E =vRSH -----END PGP SIGNATURE----- --Tcb1KvpfnM4LxW2s--