From owner-freebsd-scsi Fri Nov 22 11:14:48 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E64D737B404 for ; Fri, 22 Nov 2002 11:14:47 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id E143A43E91 for ; Fri, 22 Nov 2002 11:14:46 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 71606 invoked by uid 1000); 22 Nov 2002 19:14:47 -0000 Date: Fri, 22 Nov 2002 11:14:47 -0800 (PST) From: Nate Lawson To: Yar Tikhiy Cc: freebsd-scsi@freebsd.org Subject: Re: {da,sa,...}open bug? In-Reply-To: <20021122212846.C60810@comp.chem.msu.su> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, 22 Nov 2002, Yar Tikhiy wrote: > The XXopen() methods of the da, sa etc drivers get a reference to > the peripheral ("periph") through cam_periph_acquire() and don't > release it on error exit. I suspect this leads to CAM wedge if the > device is removed when its driver is in XXopen(). That is because > the "periph" stays acquired (refcount > 0), but the XXopen() caller > wouldn't invoke XXclose() subsequently since it sees XXopen() having > failed. Thus CAM won't ever "forget" the device removed. > > Moreover, after I had patched daopen() to release the peripheral > if returning non-zero error code, the CAM wedge has gone. Your approach sounds correct to me. open should call cam_periph_release if it errors out after cam_periph_acquire. Care to submit a patch? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message