From owner-freebsd-stable@FreeBSD.ORG Fri Jan 22 15:29:50 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 965D81065672 for ; Fri, 22 Jan 2010 15:29:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 52F428FC0C for ; Fri, 22 Jan 2010 15:29:50 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id D855A46B3B; Fri, 22 Jan 2010 10:29:49 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 1A2938A025; Fri, 22 Jan 2010 10:29:49 -0500 (EST) From: John Baldwin To: freebsd-stable@freebsd.org Date: Fri, 22 Jan 2010 10:29:43 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.2-CBSD-20091231; KDE/4.3.1; amd64; ; ) References: <4B596838.9020609@southportcomputers.co.uk> <20100122094546.GB6681@titania.njm.me.uk> <20100122111708.GA67643@icarus.home.lan> In-Reply-To: <20100122111708.GA67643@icarus.home.lan> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201001221029.43926.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 22 Jan 2010 10:29:49 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Colin , Jeremy Chadwick Subject: Re: make buildkernel failing on zfs X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2010 15:29:50 -0000 On Friday 22 January 2010 6:17:08 am Jeremy Chadwick wrote: > On Fri, Jan 22, 2010 at 09:45:46AM +0000, N.J. Mann wrote: > > In message <4B596838.9020609@southportcomputers.co.uk>, > > Colin (freebsd@southportcomputers.co.uk) wrote: > > > > > [snip] > > > It goes for a while and then the buildkernel fails with this: > > > > > > cc -O2 -fno-strict-aliasing -pipe -DFREEBSD_NAMECACHE -DBUILDING_ZFS > > > -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc > > > -I/usr/src/sys/modules/zfs/../../cddl/compat/opensolaris > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/commo > > > n/fs/zfs > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common > > > -I/usr/src/sys/modules/zfs/../.. > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/openso > > > laris/common/zfs > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/common > > > -I/usr/src/sys/modules/zfs/../../../include -DHAVE_KERNEL_OPTION_HEADERS > > > -include /usr/obj/usr/src/sys/TED/opt_global.h -I. -I@ -I@/contrib/altq > > > -finline-l > > > imit=8000 --param inline-unit-growth=100 --param > > > large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/TED > > > -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx > > > -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding - > > > Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > > > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > > > -Wno-pointer-sign -fformat-extensions -Wno-unknown-pragmas > > > -Wno-missing-prototypes -Wno-undef -Wno-strict-pro > > > totypes -Wno-cast-qual -Wno-parentheses -Wno-redundant-decls > > > -Wno-missing-braces -Wno-uninitialized -Wno-unused -Wno-inline > > > -Wno-switch -Wno-pointer-arith -c > > > /usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_z > > > node.c > > > *** Error code 1 > > > > I think this was a temporary problem that has already been fixed. Try > > updating to the latest version and see if that builds okay. > > The FreeBSD tinderbox build system noticed this problem as well, dying > in the same piece of code. It's not you. > > 738 01/21 17:04 FreeBSD Tinderbox (9.0K) [releng_7 tinderbox] failure on amd64/amd64 > 739 01/21 17:44 FreeBSD Tinderbox (8.7K) [releng_7 tinderbox] failure on i386/i386 > > Normally I'd shake my finger at the committer for committing code to > stable branches without testing, but I hold the committer (jhb) in very > high regards and he has a very established history of not breaking > things + doing excellent work. Mistakes happen, we're all human. :-) Kind words aside, in this case the testing wasn't quite adequate. While I did run-test it under UFS, I only built a GENERIC kernel w/o modules which is how I missed ZFS. Given that the patch touched ZFS I really should have built the module. -- John Baldwin