From owner-cvs-all  Tue Oct 30  8: 3:51 2001
Delivered-To: cvs-all@freebsd.org
Received: from straylight.ringlet.net (sentinel.office1.bg [217.75.129.210])
	by hub.freebsd.org (Postfix) with SMTP id C927F37B403
	for <cvs-all@FreeBSD.org>; Tue, 30 Oct 2001 08:03:44 -0800 (PST)
Received: (qmail 1963 invoked by uid 1000); 30 Oct 2001 14:46:40 -0000
Date: Tue, 30 Oct 2001 16:46:40 +0200
From: Peter Pentchev <roam@ringlet.net>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/include malloc.h
Message-ID: <20011030164640.C31154@straylight.oblivion.bg>
Mail-Followup-To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
References: <200110250235.f9P2ZTU86318@freefall.freebsd.org> <200110250239.f9P2dfn50520@khavrinen.lcs.mit.edu> <20011030161105.A93996@straylight.oblivion.bg> <200110301557.f9UFvHe25413@khavrinen.lcs.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200110301557.f9UFvHe25413@khavrinen.lcs.mit.edu>; from wollman@khavrinen.lcs.mit.edu on Tue, Oct 30, 2001 at 10:57:17AM -0500
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, Oct 30, 2001 at 10:57:17AM -0500, Garrett Wollman wrote:
> <<On Tue, 30 Oct 2001 16:11:05 +0200, Peter Pentchev <roam@ringlet.net> said:
> 
> > Just BTW, what is the correct test to use for malloc.h vs stdlib.h?
> > Will __STDC__ be enough?
> 
> #if HAVE_STDLIB_H

Eep.. :)

> __STDC__ tells you about the compiler; it doesn't tell you whether the
> compilation environment is actually valid.  In FreeBSD, we have always
> had <stdlib.h>, even when compiling with `gcc -traditional'.

Well, I figured that much.. but this does not help me much :)

I'm asking more from the standpoint of submitting fixes back to authors
of various ported software; e.g. right now, I'm struggling with a big
piece of software which has a *lot* of:

#if defined(BSDI)
#include <malloc.h>
#else
#include <stdlib.h>
#endif

I could easily change that to defined(BSDI) || defined(__FreeBSD__),
but.. you mean there really is no way to do this better? :\

Thanks anyway, though.

G'luck,
Peter

-- 
because I didn't think of a good beginning of it.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message