From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Jan  3 10:30:27 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1FD2416A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat,  3 Jan 2004 10:30:27 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0777143D41
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat,  3 Jan 2004 10:30:24 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i03IUNFR069717	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 3 Jan 2004 10:30:23 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i03IUNqY069713;
	Sat, 3 Jan 2004 10:30:23 -0800 (PST)
	(envelope-from gnats)
Date: Sat, 3 Jan 2004 10:30:23 -0800 (PST)
Message-Id: <200401031830.i03IUNqY069713@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Jeremy Messenger <mezz7@cox.net>
Subject: Re: ports/59496: New Port: x11/gtk-smooth-engine
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Jeremy Messenger <mezz7@cox.net>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Jan 2004 18:30:27 -0000

The following reply was made to PR ports/59496; it has been noted by GNATS.

From: Jeremy Messenger <mezz7@cox.net>
To: freebsd-gnats-submit@FreeBSD.org, amistry@am-productions.biz,
	edwin@FreeBSD.org
Cc: gnome@freebsd.org
Subject: Re: ports/59496: New Port: x11/gtk-smooth-engine
Date: Sat, 03 Jan 2004 12:23:31 -0600

 This one does really need to clean, so here's my feedback.
 
 	- The CATEGORIES needs to be change to 'x11-toolkits gnome',
 	  just check 'ls /usr/ports/x11-toolkits | grep gtk' to see how many
 	  gtk themes are in there. Which meaning, you should move this
 	  port from x11 to x11-toolkits.
 
 	- Need to add the 'CONFLICT= gnome-themes-extras-*',
 	  because the x11-toolkits/gnome-themes-extras has the smooth
 	  engine in there.
 
 	- Need to use the USE_GNOME= gtk12 and USE_GNOME=gtk20
 	  instead full path to the library. [1]
 
 	- Need to use the ${HAVE_GNOME:Mgtk12} instead find the
 	  the full path library to have the WITH_GTK12=yes. Same as with
 	  gtk20. You can check some examples from mplayer, AbiWord2,
 	  vim and etc. [1]
 
 	- I disagree with the SHLIB, I do not think it's need for this. Well,
 	  if you still prefer to have this then nevermind about this until
 	  someone disagree.
 
 	- Remove the 'USE_GNOME= gtk12 gtk20', which they should
 	  be inside the HAVE_GNOME or WITH_* as I have said above.
 
 	- Might need to use .include <bsd.port.pre.mk> and
 	  .include <bsd.port.post.mk>.
 
 	- Remove the '@dirrm lib/gtk-2.0/2.2.0/engines' in the pkg-plist,
 	  because this directory is belong to GTK; not any theme engine.
 
 	- Please use the portlint, the test is failed.
 
 Hope, it helps.
 
 [1] To learn more about them how to create the gtk/gnome port, visit: 
 http://www.freebsd.org/gnome/docs/porting.html
 
 BTW: I am CC'ing to gnome@freebsd.org , in case if I am missing something 
 else or I am wrong.
 
 Cheers,
 Mezz
 
 
 -- 
 bsdforums.org 's moderator, mezz.