From owner-freebsd-ports@FreeBSD.ORG Sun Apr 26 02:04:37 2009 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 394FB1065672 for ; Sun, 26 Apr 2009 02:04:37 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158]) by mx1.freebsd.org (Postfix) with ESMTP id 1093E8FC21 for ; Sun, 26 Apr 2009 02:04:33 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: by syn.atarininja.org (Postfix, from userid 1001) id A2CB45C37; Sat, 25 Apr 2009 22:04:32 -0400 (EDT) Date: Sat, 25 Apr 2009 22:04:32 -0400 From: Wesley Shields To: Jarrod Sayers Message-ID: <20090426020432.GC50348@atarininja.org> References: <20090318175949.GA56048@bewilderbeast.blackhelicopters.org> <20090424134928.K63938@familysquires.net> <20090424195309.GA50348@atarininja.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Cc: ports@FreeBSD.org, sebastian.guarino@gmail.com, "Michael L. Squires" , "Michael W. Lucas" Subject: Re: Nagios segfault on startup when embedded perl is enabled on 7.1-stable/i386 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Apr 2009 02:04:37 -0000 On Sun, Apr 26, 2009 at 11:16:42AM +0930, Jarrod Sayers wrote: > On 25/04/2009, at 5:23 AM, Wesley Shields wrote: > > There is a PR about this issue (ports/131993) but the maintainer is > > reluctant to approve the patch listed there. The maintainer has asked > > for system information from people who report this problem in the past > > (see the PR log for details) but nothing has ever come of it. It may > > be > > useful for you to send the same information to the maintainer who is, > > presumably, still interested in fixing this bug. > > Just to clarify things, yes, I do recognise there is an issue here and > yes, I am still working to find a resolution. My reluctance in > approving the patch in ports/131993 simply boils down to the fact I am > unable to even reproduce the issue, and believe me, I have tried on > many, many systems. > > The issue seems to be the passing of the embedding variable to > Perl_sys_init3 (aka PERL_SYS_INIT3). The second argument to this > function takes a char *** which init_embedded_perl() attempts to pass > to it as a pointer to a char **, err... This does generate a warning > during compilation but as to why the embedded Perl functionality still > works on my systems without faulting is beyond me. > > Sebastian's patch will resolve the problem, and with some > modifications and additional checks and warnings, I have a patch which > now needs some testing. Grab it from the URL below, dumping it in /usr/ > ports/net-mgmt/nagios/files. > > http://www.netleader.com.au/~jarrod/FreeBSD/patch-base-utils.c > > I've tested it as much as I can and don't believe it introduces a > regression on non-faulting systems so if it solves the issue for users > with faulting nagios binaries, then I will bundle it up and have it > committed. As I've said in the past, thank you for being so responsive with these ports. I will continue to monitor that PR and if the users who were having the problems can confirm the above patch fixes it then I will work with you to get it into the tree. > > Is the benefit to the embedded perl option worth the occasional bug > > report? Is it possible to remove this option from the port? > > I believe so, systems with many Perl based probes do benefit from > starting just one instance of the interpreter. Fair enough. Thanks again for your continued work on these ports. -- WXS