From owner-freebsd-current@FreeBSD.ORG  Thu Jun 16 01:07:58 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.ORG
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A29716A41F
	for <current@FreeBSD.ORG>; Thu, 16 Jun 2005 01:07:58 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from harmony.village.org (vc4-2-0-66.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E1BA143D49
	for <current@FreeBSD.ORG>; Thu, 16 Jun 2005 01:07:57 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.13.3/8.13.3) with ESMTP id j5G16vHW030582;
	Wed, 15 Jun 2005 19:06:58 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Wed, 15 Jun 2005 14:34:03 -0600 (MDT)
Message-Id: <20050615.143403.58435323.imp@bsdimp.com>
To: brooks@one-eyed-alien.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20050615202355.GA12986@odin.ac.hmc.edu>
References: <20050615230844.G61956@mp2.macomnet.net>
	<20050615.135552.74722719.imp@bsdimp.com>
	<20050615202355.GA12986@odin.ac.hmc.edu>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: current@FreeBSD.ORG
Subject: Re: ed(4) broken?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2005 01:07:58 -0000

In message: <20050615202355.GA12986@odin.ac.hmc.edu>
            Brooks Davis <brooks@one-eyed-alien.net> writes:
: On Wed, Jun 15, 2005 at 01:55:52PM -0600, Warner Losh wrote:
: > From: Maxim Konovalov <maxim@macomnet.ru>
: > Subject: Re: ed(4) broken?
: > Date: Wed, 15 Jun 2005 23:14:52 +0400 (MSD)
: > 
: > > On Wed, 15 Jun 2005, 00:27-0600, M. Warner Losh wrote:
: > > 
: > > > In message: <20050614231344.F76340@mp2.macomnet.net>
: > > >             Maxim Konovalov <maxim@macomnet.ru> writes:
: > > > : Latest GENERIC in qemu produces
: > > > : Jun 14 19:12:04 qemu6 kernel: ed_start(0xc12e5000) GONE
: > > > : Jun 14 19:12:07 qemu6 kernel: ed0: NIC memory corrupt - invalid packet length 45
: > > > : No real hardware though.
: > > >
: > > > ed works for me on all the real hardware I have.  Maybe you could give
: > > > me more details.
: > > 
: > > Something between 2005/06/10 00:00 UTC and 2005/06/11 00:00 UTC broke
: > > qemu's ed(4).  I'm still not sure it's not qemu problem.  No
: > > additional info so far, sorry.
: > 
: > That's when the big, jumbo ifnet patch went in.  I eyeballed the
: > changes and can see nothing wrong by visual inspection.
: 
: I've looked to code over closely again and I'm supprised it works for
: anyone.  I found four instances of casts of sc to get ifp including one
: if sc_xmit.  I must have missed them when reconverting the driver after
: your cleanup. :(  I've commited a fix for them.

I don't think I've actually tested it on real hardware since June 8th,
so this isn't surprising...

Warner