From owner-freebsd-ports@FreeBSD.ORG Thu Nov 8 14:56:59 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 01CAEB85; Thu, 8 Nov 2012 14:56:58 +0000 (UTC) (envelope-from jnagyjr1978@gmail.com) Received: from mail-ye0-f182.google.com (mail-ye0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8771B8FC0A; Thu, 8 Nov 2012 14:56:58 +0000 (UTC) Received: by mail-ye0-f182.google.com with SMTP id l8so568946yen.13 for ; Thu, 08 Nov 2012 06:56:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=BugXFd7blUjydG3Ft8MguliwAqNL9CwM8gBXM2P/9lE=; b=o4dGfZTOpSAb3P6ySG1omZIeR/+v65khgtXwPpAHGyY0EajhjudPB3jAqdaGEnJ0eQ Viv/YZVbrJV9YN1oxuqZBDc6a7SK0INV6oWaQsB+Ptk12WXy7v8YtuP/2yJupVOyiPJB HWRM+2sfmrS01WguVIviLhDRoMmOMbP//hoOiM2/Cn2ws8VPIwvLreGr2CmlJXdR4Iil DmJS7J4+8ITfv0plTG03GVE3IVPMBGQ5YDMgmDOKM//ZAbt8U4nhG0xKXpgms/RijJz6 bR3JZfbb6Y/sPlQaxkN14u5yNJvq6TlhgL0YMJEQU+jnR1YYqSZjiqoQFsyn7KImetYe TGvw== Received: by 10.101.128.5 with SMTP id f5mr2408676ann.6.1352386611876; Thu, 08 Nov 2012 06:56:51 -0800 (PST) Received: from alex-laptop.localhost (vid-196.dhcp.grp10.tnmmrl.infoave.net. [204.116.254.196]) by mx.google.com with ESMTPS id a44sm27018070yhe.21.2012.11.08.06.56.50 (version=SSLv3 cipher=OTHER); Thu, 08 Nov 2012 06:56:50 -0800 (PST) Message-ID: <509BC82E.2000206@gmail.com> Date: Thu, 08 Nov 2012 08:56:46 -0600 From: Joseph a Nagy Jr User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:16.0) Gecko/20121022 Thunderbird/16.0.1 MIME-Version: 1.0 To: gahr@FreeBSD.org Subject: Re: tk85 Port Maintenance References: <20121031152109.GD90275@gahrfit.gahr.ch> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch> <50968056.8080602@gmail.com> <20121106082040.GM90275@gahrfit.gahr.ch> <509AEACB.1020909@gmail.com> <20121108091333.GN90275@gahrfit.gahr.ch> In-Reply-To: <20121108091333.GN90275@gahrfit.gahr.ch> X-Enigmail-Version: 1.4.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig91B02D1EE9430BFF34BFFF14" X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: ports@freebsd.org, Chris Rees X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2012 14:56:59 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig91B02D1EE9430BFF34BFFF14 Content-Type: multipart/mixed; boundary="------------060705010604060003050502" This is a multi-part message in MIME format. --------------060705010604060003050502 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/08/12 03:13, Pietro Cerutti wrote: > On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote: >> On 11/06/12 02:20, Pietro Cerutti wrote: >> >>> * I won't comment on the LICENSE stuff, I don't know enough about it >>> >>> * XFT_DESC >>> This is already defined in bsd.options.desc.mk. I'd say that=20 >>> "Xft font library" is ok as a description. >>> >>> * LIB_DEPENDS+=3D Xft:${PORTSDIR}/x11-fonts/libXft >>> This should really be >>> USE_XORG+=3D xft >>> >>> * LIB_DEPENDS=3D tcl${SHORT_TK_VER}${THREADS_SUFFIX}:.... >>> If you're ok to wait until I get rid of the -thread slave ports, >>> you don't need to bother about this part of the Makefile >>> >> >> svn checked out, svn diff >> >> http://pastebin.com/kLdUFp9H >=20 > -XFT_DESC=3D Use Xft fonts > +XFT_DESC=3D Xft font library >=20 > This is not needed. As I said, XFT_DESC is already defined in > bsd.options.desc.mk Sorry, misunderstood. >=20 > The tr -> ${TR} conversion is also wrong, you're changing what the sed > liner is looking for. If you do so, it won't find it anymore. That was one of many suggestions from portlint. > By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days > (the first RC is out now, actually). You might want to include the > update in your diff :) >=20 I'll get on it. --=20 Yours in Christ, Joseph A Nagy Jr "Whoever loves instruction loves knowledge, But he who hates correction is stupid." -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org --------------060705010604060003050502-- --------------enig91B02D1EE9430BFF34BFFF14 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQm8gwAAoJECqR4kIlFcuBsKYIAJ/t/BuxOJFRneQy08lxsJzn PsoK5FZBYkRmhm7VisMZZ+FBdagybgGUEF79KSzGwAIkWVcYr24Pv6yZC0PBTbFp m/1DQ9jkb8l2UqtX4uLrfLFbHig0g5MZo8hywNjY1jK1P/QBathbPgjRzxqY4hck NtNqLDjEjLDPKiv/ft+l1AO2hHbObw4fR/pRLRIYsjUov7ypaX4ocQj+RlI9+vpO ep4BxfPYWjWTHpENIU16+ePzbHUnTAOAFN8nEdwHn8KhkOOwdNkLpz3UZfHiFCMt Rb/vcLHngP1KH2z2+NVKypslajj4Nt4ozLrZZCpd953lC7hV9aioQjgVGCkJuiQ= =YFqP -----END PGP SIGNATURE----- --------------enig91B02D1EE9430BFF34BFFF14--