From owner-freebsd-scsi@FreeBSD.ORG  Tue Dec  1 18:25:02 2009
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: scsi@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 52641106566B
	for <scsi@FreeBSD.org>; Tue,  1 Dec 2009 18:25:02 +0000 (UTC)
	(envelope-from jh@FreeBSD.org)
Received: from gw03.mail.saunalahti.fi (gw03.mail.saunalahti.fi
	[195.197.172.111])
	by mx1.freebsd.org (Postfix) with ESMTP id 163A98FC17
	for <scsi@FreeBSD.org>; Tue,  1 Dec 2009 18:25:01 +0000 (UTC)
Received: from a91-153-117-195.elisa-laajakaista.fi
	(a91-153-117-195.elisa-laajakaista.fi [91.153.117.195])
	by gw03.mail.saunalahti.fi (Postfix) with SMTP id 757E4216626
	for <scsi@FreeBSD.org>; Tue,  1 Dec 2009 20:05:25 +0200 (EET)
Date: Tue, 1 Dec 2009 20:05:25 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: scsi@FreeBSD.org
Message-ID: <20091201180524.GB7961@a91-153-117-195.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: 
Subject: cd(4) M_WAITOK allocations with periph lock held
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2009 18:25:02 -0000


Hi,

There are some M_WAITOK malloc invocations with periph lock held in
cd(4). Below is a link to a patch which drops the periph lock while
doing those allocations. Comments/review?

---

Drop periph lock while allocating memory with M_WAITOK flag in
cdreportkey(), cdsendkey() and cdreaddvdstructure().

PR:		kern/130735
Tested by:	Eygene Ryabinkin

The patch against head:

http://people.freebsd.org/~jh/patches/scsi_cd-M_WAITOK-fixes.diff

-- 
Jaakko