From owner-freebsd-current Sun Mar 25 20:47:14 2001 Delivered-To: freebsd-current@freebsd.org Received: from filk.iinet.net.au (syncopation-dns.iinet.net.au [203.59.24.29]) by hub.freebsd.org (Postfix) with SMTP id EE25D37B71D for ; Sun, 25 Mar 2001 20:47:10 -0800 (PST) (envelope-from julian@elischer.org) Received: (qmail 2255 invoked by uid 666); 26 Mar 2001 04:48:52 -0000 Received: from i079-150.nv.iinet.net.au (HELO elischer.org) (203.59.79.150) by mail.m.iinet.net.au with SMTP; 26 Mar 2001 04:48:52 -0000 Message-ID: <3ABEC9C7.F6C759CA@elischer.org> Date: Sun, 25 Mar 2001 20:47:04 -0800 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 To: current@freebsd.org Subject: si_drv1 used already? Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG The vmware vmmon driver used to use si_drv1 but suddenly it appears to have already been used (at least it is no-longer non-zero). It would fail to open because it checks it before using it during open. Changing the driver to use si_drv2 fixes the problem. Since drv1 is defined as 'for the use of the driver' I am not sure that it is wrong for the driver to use it. In fact many other drivers do use it without testing it. I see it's used in freedev() and make_dev_alias(). Is it safe for the driver to use it even if it is non-zero? -- __--_|\ Julian Elischer / \ julian@elischer.org ( OZ ) World tour 2000-2001 ---> X_.---._/ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message