From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jul 28 19:10:01 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB72E1065673 for ; Mon, 28 Jul 2008 19:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7BF568FC1C for ; Mon, 28 Jul 2008 19:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6SJA1gG025570 for ; Mon, 28 Jul 2008 19:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6SJA1L1025569; Mon, 28 Jul 2008 19:10:01 GMT (envelope-from gnats) Resent-Date: Mon, 28 Jul 2008 19:10:01 GMT Resent-Message-Id: <200807281910.m6SJA1L1025569@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Josh Carroll Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B4A61065670 for ; Mon, 28 Jul 2008 19:05:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 1E5F28FC16 for ; Mon, 28 Jul 2008 19:05:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6SJ5AJp052176 for ; Mon, 28 Jul 2008 19:05:10 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m6SJ5Al9052175; Mon, 28 Jul 2008 19:05:10 GMT (envelope-from nobody) Message-Id: <200807281905.m6SJ5Al9052175@www.freebsd.org> Date: Mon, 28 Jul 2008 19:05:10 GMT From: Josh Carroll To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/126045: ffmpeg port needs --enable-nonfree with --enable-libamr* X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2008 19:10:01 -0000 >Number: 126045 >Category: ports >Synopsis: ffmpeg port needs --enable-nonfree with --enable-libamr* >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 28 19:10:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Josh Carroll >Release: 7.0-RELEASE/amd64 >Organization: N/A >Environment: FreeBSD pflog.net 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Tue Feb 26 01:20:52 EST 2008 root@pflog.net:/usr/obj/usr/src/sys/PFLOG amd64 >Description: The ffmpeg upstream source now requires --enable-nonfree when compiling with certain options, currently either of: --enable-libamr-nb --enable-libamr-wb I have attached a patch to add a "NONFREE" option, which adds --enable-nonfree to CONFIGURE_ARGS, and also a check that WITH_NONFREE is set if WITH_AMR_NB or WITH_AMR_WB are set to the pre-configure target. Alternatively, --enable-nonfree could just be set automatically if either AMR_NB or AMR_WB are set, but I think since ffmpeg then builds as a non-distributable release, it might be better to have the user explicitly request non-free support. adding --enable-nonfree in the case of AMR_NB or AMR_WB being selected is trivial, so I didn't bother including a patch for that. Thanks! Josh >How-To-Repeat: cd /usr/ports/multimedia/ffmpeg make -DWITH_AMR_NB Note the error from ffmpeg's configure script: ===> Configuring for ffmpeg-2008.07.27 libamr is nonfree and --enable-nonfree is not specified. >Fix: Please see the attached patch. Patch attached with submission follows: --- Makefile.orig 2008-07-28 14:55:34.000000000 -0400 +++ Makefile 2008-07-28 14:53:21.000000000 -0400 @@ -33,7 +33,8 @@ THEORA "libtheora support (implies OGG)" on \ VORBIS "libvorbisenc support (implies OGG)" on \ X264 "X.264 codec" on \ - XVID "XVID codec" off + XVID "XVID codec" off \ + NONFREE "non-free codec support" off .include @@ -110,6 +111,11 @@ CONFIGURE_ARGS+= --disable-libfaad .endif +## non-free support +.ifdef(WITH_NONFREE) +CONFIGURE_ARGS+= --enable-nonfree +.endif + ## amr .ifdef(WITH_AMR_NB) LIB_DEPENDS+= amrnb.3:${PORTSDIR}/audio/libamrnb @@ -206,6 +212,12 @@ .if defined(WITHOUT_VHOOK) && (defined(WITH_VHOOK_FREETYPE2) || defined(WITH_VHOOK_IMLIB2)) @${ECHO_MSG} WITH_VHOOK_FREETYPE2 or WITH_VHOOK_IMLIB2 defined, video hooks will be built .endif +.if !defined(WITH_NONFREE) && (defined(WITH_AMR_NB) || defined(WITH_AMR_WB)) + @${ECHO_MSG} "" + @${ECHO_MSG} "ERROR: AMR_WB and AMR_NB require the NONFREE option." + @${ECHO_MSG} "" + @${FALSE} +.endif post-patch: # Faad compat >Release-Note: >Audit-Trail: >Unformatted: