From owner-freebsd-embedded@FreeBSD.ORG Tue Dec 13 08:00:51 2011 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E77001065673; Tue, 13 Dec 2011 08:00:51 +0000 (UTC) (envelope-from stb@lassitu.de) Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea]) by mx1.freebsd.org (Postfix) with ESMTP id A54818FC08; Tue, 13 Dec 2011 08:00:51 +0000 (UTC) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id F32265729B; Tue, 13 Dec 2011 09:00:50 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=iso-8859-1 From: Stefan Bethke In-Reply-To: Date: Tue, 13 Dec 2011 09:00:50 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <55D569DB-875B-412B-8650-C56F85D8E327@lassitu.de> References: <68ABED76-CB1F-405A-8036-EC254F7511FA@lassitu.de> <3B3DB17D-BF87-40EE-B1C1-445F178E8844@lassitu.de> <86030CEE-6839-4B96-ACDC-2BA9AC1E4AE4@lassitu.de> <2D625CC9-A0E3-47AA-A504-CE8FB2F90245@lassitu.de> <203BF1C8-D528-40C9-8611-9C7AC7E43BAB@lassitu.de> <3C0E9CA3-E130-4E9A-ABCC-1782E28999D1@lassitu.de> <6387ABA5-AC55-49DD-9058-E45CC0A3E0A0@lassitu.de> <74E4AF57-3D22-415E-B913-176753B09B16@lassitu.de> <710E2C7A-E9AC-4103-8C61-0EDC4A3AF9DE@lassitu.de> <24FB4633-B729-4582-9FF6-CA8656742985@lassitu.de> To: Adrian Chadd X-Mailer: Apple Mail (2.1251.1) Cc: freebsd-embedded@freebsd.org Subject: Re: TL-WR1043: switch X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2011 08:00:52 -0000 Am 13.12.2011 um 02:41 schrieb Adrian Chadd: > Hm, it seems your etherswitchcfg code is reusing code from ifconfig? > Or is that code from ray? >=20 > Just a nitpick, we should likely avoid that code duplication and > either roll this into ifconfig, or should we just break out the > ifconfig related code into a shared library and reuse that? Ultimately, that would be the correct way. I'd start working on that = once it's clear that this is the way forward. Integrating the switch configuration code into ifconfig has crossed my = mind, but I think the overlap is too small to make sense. While the = media code manipulates the same data structures (struct ifreq, struct = ifmediareq), the ioctls are completely different, so much of the = ifconfig infrastructure is actually in the way. I'm using sbin/ifconfig/if_media.c unchanged except for exporting some = of the low level functions for printing and parsing media and mediaopt. = I'm not certain where this code would go to be shared efficiently. = Also, wherever it goes ifconfig still needs to be buildable for /rescue. Stefan --=20 Stefan Bethke Fon +49 151 14070811