From owner-cvs-all@FreeBSD.ORG  Wed Jun 27 19:42:12 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3AC301065670;
	Wed, 27 Jun 2012 19:42:12 +0000 (UTC) (envelope-from ache@vniz.net)
Received: from vniz.net (vniz.net [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 6493F8FC0C;
	Wed, 27 Jun 2012 19:42:05 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by vniz.net (8.14.5/8.14.5) with ESMTP id q5RJdYMV017426;
	Wed, 27 Jun 2012 23:39:34 +0400 (MSK) (envelope-from ache@vniz.net)
Received: (from ache@localhost)
	by localhost (8.14.5/8.14.5/Submit) id q5RJdYV5017425;
	Wed, 27 Jun 2012 23:39:34 +0400 (MSK) (envelope-from ache)
Date: Wed, 27 Jun 2012 23:39:34 +0400
From: Andrey Chernov <ache@FreeBSD.ORG>
To: Xin LI <delphij@FreeBSD.ORG>
Message-ID: <20120627193934.GA17292@vniz.net>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Xin LI <delphij@FreeBSD.ORG>, ports-committers@FreeBSD.ORG,
	cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <201206270022.q5R0Mt8X097020@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201206270022.q5R0Mt8X097020@repoman.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG
Subject: Re: cvs commit: ports/security/sshguard Makefile
 ports/security/sshguard/files pkg-message.in sshguard.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2012 19:42:12 -0000

On Wed, Jun 27, 2012 at 12:22:55AM +0000, Xin LI wrote:
> delphij     2012-06-27 00:22:55 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     security/sshguard    Makefile 
>     security/sshguard/files pkg-message.in 
>   Added files:
>     security/sshguard/files sshguard.in 
>   Log:
>   Add a rc.d script to daemonize sshguard.
>   
>   Submitted by:   delphij
>   PR:             ports/166471
>   Approved by:    maintainer timeout (~3 months)

In sshguard.in:

1) You use
sshguard_blacklist="40:/var/db/sshguard/blacklist.db"
where thr (40) is too low. sshguard(1) manpage have error: according to 
source code thr is measured in
(number_of_abuses * DEFAULT_ABUSE_THRESHOLD)
with default
(3 * DEFAULT_ABUSE_THRESHOLD)
and not in simple number_of_abuses as manpage states. Since 
DEFAULT_ABUSE_THRESHOLD is 10, 400 is what you mean.

2) What about users which don't want any permament blacklist? Currently
sshguard_blacklist is required parameter, since -b is hardcoded in 
the command line.

-- 
http://ache.vniz.net/