From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 6 01:00:05 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A855C16A420 for ; Thu, 6 Dec 2007 01:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8277E13C458 for ; Thu, 6 Dec 2007 01:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lB6105Hk077885 for ; Thu, 6 Dec 2007 01:00:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lB6105ib077884; Thu, 6 Dec 2007 01:00:05 GMT (envelope-from gnats) Resent-Date: Thu, 6 Dec 2007 01:00:05 GMT Resent-Message-Id: <200712060100.lB6105ib077884@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nikos Ntarmos Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 199E416A419 for ; Thu, 6 Dec 2007 00:52:55 +0000 (UTC) (envelope-from ntarmos@ceid.upatras.gr) Received: from poseidon.ceid.upatras.gr (poseidon.ceid.upatras.gr [150.140.141.169]) by mx1.freebsd.org (Postfix) with ESMTP id 903F813C448 for ; Thu, 6 Dec 2007 00:52:54 +0000 (UTC) (envelope-from ntarmos@ceid.upatras.gr) Received: from mail.ceid.upatras.gr (unknown [10.1.0.143]) by poseidon.ceid.upatras.gr (Postfix) with ESMTP id F2325EB4D5E; Thu, 6 Dec 2007 02:52:52 +0200 (EET) Received: from localhost (europa.ceid.upatras.gr [127.0.0.1]) by mail.ceid.upatras.gr (Postfix) with ESMTP id D98F3158E88; Thu, 6 Dec 2007 02:52:52 +0200 (EET) Received: from mail.ceid.upatras.gr ([127.0.0.1]) by localhost (europa.ceid.upatras.gr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wFtQ02jSGjgb; Thu, 6 Dec 2007 02:52:52 +0200 (EET) Received: from ace.netcins.ceid.upatras.gr (vfppp079167010191.dsl.hol.gr [79.167.10.191]) by mail.ceid.upatras.gr (Postfix) with ESMTP id 8A52B158E35; Thu, 6 Dec 2007 02:52:52 +0200 (EET) Received: by ace.netcins.ceid.upatras.gr (Postfix, from userid 1001) id 2F9BB3F40F; Thu, 6 Dec 2007 02:52:51 +0200 (EET) Message-Id: <20071206005251.2F9BB3F40F@ace.netcins.ceid.upatras.gr> Date: Thu, 6 Dec 2007 02:52:51 +0200 (EET) From: Nikos Ntarmos To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: relaxbsd@gmail.com Subject: ports/118456: [Patch] x11/roxterm doesn't match URLs properly X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Nikos Ntarmos List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2007 01:00:05 -0000 >Number: 118456 >Category: ports >Synopsis: [Patch] x11/roxterm doesn't match URLs properly >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 06 01:00:04 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Nikos Ntarmos >Release: FreeBSD 7.0-BETA3 i386 >Organization: NetCInS Lab., C.E.I.D., U. of Patras, Greece >Environment: System: FreeBSD ace.netcins.ceid.upatras.gr 7.0-BETA3 FreeBSD 7.0-BETA3 #0: Sat Dec 1 16:55:25 EET 2007 root@ace.netcins.ceid.upatras.gr:/opt/obj/opt/src/sys/ACE i386 >Description: x11/roxterm features vte-based matching of URLs on screen, assigned to user-programmable handlers. The current regexs used to define URLs don't function correctly; a URL is supposed to begin on '\<' (start of word) but the regex engine matches the literal '<', resulting in considering only URLs with a leading '<', including the '<' character. The upstream author is further considering changing '\<' to '\b' (word boundary), but that doesn't work either. >How-To-Repeat: Run x11/roxterm and hover the mouse over a url not starting with '<'. >Fix: Note that a similar workaround has been used for x11/gnome-terminal too. --- roxterm-url-matching.diff begins here --- --- /dev/null 2007-12-06 02:40:59.000000000 +0200 +++ files/patch-src-roxterm.c 2007-12-06 02:35:09.000000000 +0200 @@ -0,0 +1,53 @@ +--- src/roxterm.c.orig 2007-12-05 22:06:09.000000000 +0200 ++++ src/roxterm.c 2007-12-05 22:14:11.000000000 +0200 +@@ -169,7 +169,8 @@ + } + + #define URLMSGIDSET "[-A-Z\\^_a-z{|}~!\"#$%&'()*+,./0-9;:=?`]" +-#define URLEND "[^]'.}>) \t\r\n,\\\"]" ++#define URLEND "[^]'.}>) \t\r\n,\\\"]" "[[:>:]]" ++#define URLSTART "[[:<:]]" + #define URLHOST "[A-Za-z0-9][-A-Za-z0-9.]*" + #define URLEXTHOST "[A-Za-z0-9][-.:!%$^*&~#A-Za-z0-9@]*" + #define URLFQDNTAIL "\\.[-A-Za-z0-9.]+" +@@ -180,30 +181,30 @@ + #define URLUSERANDPASS URLUSER ":[-,?;.:/!%$^*&~\"#'A-Za-z0-9]+" + #define URLPORT ":[0-9]+" + */ +-#define URLPATH "[/?][-A-Za-z0-9_$.+!*(),;:@&=?/~#%]*" URLEND ++#define URLPATH "[/?][-A-Za-z0-9_$.+!*(),;:@&=?/~#%]*" + + static const char *full_urls[] = { +- "\\<" URLSCHEME "//" URLEXTHOST, +- "\\<" URLSCHEME "//" URLEXTHOST URLPATH ++ URLSTART URLSCHEME "//" URLEXTHOST URLEND "/?", ++ URLSTART URLSCHEME "//" URLEXTHOST URLPATH URLEND "/?" + }; + + static const char *web_urls[] = { +- "\\Release-Note: >Audit-Trail: >Unformatted: