From owner-freebsd-usb@FreeBSD.ORG  Fri Apr  8 19:42:33 2005
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0950916A4CE
	for <usb@FreeBSD.org>; Fri,  8 Apr 2005 19:42:33 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 90B7A43D41
	for <usb@FreeBSD.org>; Fri,  8 Apr 2005 19:42:32 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.13.3/8.13.1) with ESMTP id j38Je1F2000112;
	Fri, 8 Apr 2005 13:40:01 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Fri, 08 Apr 2005 13:40:01 -0600 (MDT)
Message-Id: <20050408.134001.71185996.imp@bsdimp.com>
To: WillS@housing.ufl.edu
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <0E972CEE334BFE4291CD07E056C76ED8062D2491@bragi.housing.ufl.edu>
References: <0E972CEE334BFE4291CD07E056C76ED8062D2491@bragi.housing.ufl.edu>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: usb@FreeBSD.org
Subject: Re: Please commit fix outlined in PR/63837
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2005 19:42:33 -0000

From: "Will Saxon" <WillS@housing.ufl.edu>
Subject: Please commit fix outlined in PR/63837
Date: Fri, 8 Apr 2005 15:34:14 -0400

> Is it possible to get the 1 line fix posted in PR/63837 added 
> before 5.4? This has been a problem since before 5.3, the fix is 
> trivial and it works fine.
> 
> It is kind of annoying to have to edit hid.c every time I cvsup.
> 
> This has been asked about before by myself and others... Is there
> a stylistic problem or a planned cleanup that has held this back?
> 
> --- /usr/src/sys/dev/usb/hid.c.orig  Fri Apr  8 15:26:46 2005
> +++ /usr/src/sys/dev/usb/hid.c       Fri Apr  8 14:55:01 2005
> @@ -375,7 +375,7 @@
> 
> 	id = 0;
> 	for (d = hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
> -		if (h.report_ID != 0)
> + 		if (h.report_ID != 0 && !id)
> 			id = h.report_ID;
> 	hid_end_parse(d);
> 	size = h.loc.pos;

So this patch just makes report_ID the FIRST id in the item list,
right?

Warner