From owner-freebsd-ports  Wed May 17 13:06:16 1995
Return-Path: ports-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id NAA12752
          for ports-outgoing; Wed, 17 May 1995 13:06:16 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id NAA12746
          for <ports@FreeBSD.org>; Wed, 17 May 1995 13:06:11 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id NAA12278; Wed, 17 May 1995 13:05:05 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199505172005.NAA12278@gndrsh.aac.dev.com>
Subject: Re: SUBDIR in Makefiles - usage thereof
To: asami@CS.Berkeley.EDU (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=)
Date: Wed, 17 May 1995 13:05:05 -0700 (PDT)
Cc: jhs@vector.eikon.e-technik.tu-muenchen.de, ports@FreeBSD.org
In-Reply-To: <199505171704.KAA03565@silvia.HIP.Berkeley.EDU> from "Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=" at May 17, 95 10:04:23 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1495      
Sender: ports-owner@FreeBSD.org
Precedence: bulk

> 
>  * 	SUBDIR?=
>  * 	SUBDIR += this 
>  * 	SUBDIR += that 
>  * 	SUBDIR += the_other 
>  * 	SUBDIR += foobar
> 
> Actually I thought about this before when I was cleaning up the
> Makefiles, the reason why I didn't want to go for it at that time was
> because I thought it will make the subdir Makefiles too long and
> scroll off my screen.

This is a good idea!

...
> Also, it will make it easier when we formally support the RESTRICTED
> and BROKEN keywords, as we can do something like
> 
> BROKEN     += a_broken_port
> SUBDIR     += a_good_port
> RESTRICTED += cryptic_port
> SUBDIR     += great_port
> SUBDIR     += some_port
> RESTRICTED += what_a_jerk

Another Good Idea(TM), infact his one is a Better Idea!!

> and still have them in alphabetical order. :)
> 
>  * This minor change buys flexibility, it's also been tried & tested before
>  * (& is still to be seen in such files as src/Makefile)
> 
> BTW, I definitely don't want turn this into a sea of
> 
> .if exists(foodir)
> SUBDIR += foodir
> .endif

Please don't I am about to rewrite that into something like this:

SUBDIR=
.for i in ${DIRLIST}
.if exits(${i})
	SUBDIR+= ${i}
.endif
.endfor

> the next 24 hours or so, I'll go ahead and update all the Makefiles.

I object, you are in code freeze, don't go do a wide sweeping change
like this, wait for after 2.0.5.


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD