From owner-freebsd-current@FreeBSD.ORG  Tue Jun 22 06:33:43 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6CEB916A4CE; Tue, 22 Jun 2004 06:33:43 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D103C43D45; Tue, 22 Jun 2004 06:33:42 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i5M6XfsG033558;
	Tue, 22 Jun 2004 08:33:41 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 22 Jun 2004 05:34:02 BST."
             <6.1.0.6.1.20040622051016.03cae4e8@popserver.sfu.ca> 
Date: Tue, 22 Jun 2004 08:33:41 +0200
Message-ID: <33557.1087886021@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: grog@freebsd.org
cc: chancedj@yahoo.com
cc: current@freebsd.org
Subject: Re: vinum crashing with latest current 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2004 06:33:43 -0000

In message <6.1.0.6.1.20040622051016.03cae4e8@popserver.sfu.ca>, Colin Percival
 writes:
>Now, I'm not sure which of these is correct, but ONE of the following
>two patches should be applied:
>--- src/sys/dev/vinum/vinumio.c	17 Jun 2004 17:16:47 -0000	1.99
>+++ src/sys/dev/vinum/vinumio.c	22 Jun 2004 04:29:08 -0000
>@@ -68,7 +68,7 @@ open_drive(struct drive *drive, struct t
> 	drive->lasterror = ENOTBLK;
>     else {
>         DROP_GIANT();
>-	drive->lasterror = (dsw->d_open) (drive->dev, FWRITE | FREAD, 0, NULL);
>+	drive->lasterror = (dsw->d_open) (drive->dev, FWRITE | FREAD, 0, td);
>         PICKUP_GIANT();
>     }
> 

It'll have to be this one.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.