From owner-cvs-all  Mon Apr  1 21:11:45 2002
Delivered-To: cvs-all@freebsd.org
Received: from 12-234-96-171.client.attbi.com (12-234-96-171.client.attbi.com [12.234.96.171])
	by hub.freebsd.org (Postfix) with ESMTP
	id 78F8D37B41F; Mon,  1 Apr 2002 21:11:40 -0800 (PST)
Received: by 12-234-96-171.client.attbi.com (Postfix, from userid 1000)
	id 048C57D2; Mon,  1 Apr 2002 21:10:36 -0800 (PST)
Date: Mon, 1 Apr 2002 21:10:36 -0800
From: Jonathan Mini <mini@haikugeek.com>
To: Robert Watson <rwatson@FreeBSD.ORG>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: www/en/smp index.sgml
Message-ID: <20020401211036.C68138@stylus.haikugeek.com>
Mail-Followup-To: Robert Watson <rwatson@FreeBSD.ORG>,
	cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200204020447.g324lZg60015@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200204020447.g324lZg60015@freefall.freebsd.org>; from rwatson@FreeBSD.ORG on Mon, Apr 01, 2002 at 08:47:35PM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Robert Watson [rwatson@FreeBSD.ORG] wrote :
> rwatson     2002/04/01 20:47:35 PST
> 
>   Modified files:
>     en/smp               index.sgml 
>   Log:
>   Document Jonathan Mini's sysctl locking work.  I'm not sure I understand
>   exactly what MEMLOCK() protects, so there should really be more comments
>   in kern_sysctl.c.  Once they're there, I'll update the task.
>   
>   Document Jake's addition of a userland tool to manage KTR event dumps.

So:

--- sys/kern/kern_sysctl.c,old	Mon Apr  1 21:05:33 2002
+++ sys/kern/kern_sysctl.c	Mon Apr  1 21:07:07 2002
@@ -59,7 +59,7 @@
 static MALLOC_DEFINE(M_SYSCTLOID, "sysctloid", "sysctl dynamic oids");
 
 /*
- * Locking and stats
+ * Locking - this locks the sysctl tree in memory.
  */
 static struct sx memlock;
 

Perhaps it would be a better idea to change MEMLOCK() to something like
SYSCTL_TREE_LOCK(), or perhaps just SYSCTL_LOCK(). It's only called MEMLOCK()
because phk called the old lock "memlock," which is a pretty silly reason.

>   Revision  Changes    Path
>   1.62      +16 -1     www/en/smp/index.sgml
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe cvs-all" in the body of the message

-- 
Jonathan Mini
mini@haikugeek.com

<baka^ni> desolation... despair... plastic forks...


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message