From owner-svn-src-all@FreeBSD.ORG Tue Jun 21 13:07:20 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0AD02106566C; Tue, 21 Jun 2011 13:07:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D59FB8FC12; Tue, 21 Jun 2011 13:07:19 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8C95F46B06; Tue, 21 Jun 2011 09:07:19 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1EFAA8A01F; Tue, 21 Jun 2011 09:07:19 -0400 (EDT) From: John Baldwin To: Jack F Vogel Date: Tue, 21 Jun 2011 09:07:17 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201106202259.p5KMxT1h069297@svn.freebsd.org> In-Reply-To: <201106202259.p5KMxT1h069297@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106210907.18414.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 21 Jun 2011 09:07:19 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223350 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 13:07:20 -0000 On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: > Author: jfv > Date: Mon Jun 20 22:59:29 2011 > New Revision: 223350 > URL: http://svn.freebsd.org/changeset/base/223350 > > Log: > Eliminate some global tuneables in favor of adapter-specific, > particular flow control and dma coalesce. Also improve the > sysctl operation on those too. > > Add IPv6 detection in the ioctl code, this was done for > ixgbe first, carrying that over. > > Add resource ability to disable particular adapter. > > Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. -- John Baldwin