From owner-cvs-all@FreeBSD.ORG  Tue Jun 17 09:01:56 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D1F637B409
	for <cvs-all@FreeBSD.org>; Tue, 17 Jun 2003 09:01:56 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9A36B43FBD
	for <cvs-all@FreeBSD.org>; Tue, 17 Jun 2003 09:01:54 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 54854 invoked by uid 1000); 17 Jun 2003 16:01:55 -0000
Date: Tue, 17 Jun 2003 09:01:55 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Jeff Roberson <jeff@FreeBSD.org>
In-Reply-To: <20030617102141.160C037B417@hub.freebsd.org>
Message-ID: <20030617090055.N54837@root.org>
References: <20030617102141.160C037B417@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sched_ule.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jun 2003 16:01:56 -0000

On Tue, 17 Jun 2003, Jeff Roberson wrote:
>    - Temporarily patch a problem where the interact score could be negative
>      because the run time exceeds the largest value a signed int can hold.
>      The real solution involves calculating how far we are over the limit.
>      To quickly solve this problem we loop removing 1/5th of the current value
>      until it falls below the limit.  The common case requires no passes.
>
> --- src/sys/kern/sched_ule.c:1.42	Mon Jun 16 23:39:51 2003
> +++ src/sys/kern/sched_ule.c	Tue Jun 17 03:21:34 2003
> @@ -627,7 +627,8 @@
>  static void
>  sched_interact_update(struct ksegrp *kg)
>  {
> -	if ((kg->kg_runtime + kg->kg_slptime) >  SCHED_SLP_RUN_MAX) {
> +	/* XXX Fixme, use a linear algorithm and not a while loop. */
> +	while ((kg->kg_runtime + kg->kg_slptime) >  SCHED_SLP_RUN_MAX) {
>  		kg->kg_runtime = (kg->kg_runtime / 5) * 4;
>  		kg->kg_slptime = (kg->kg_slptime / 5) * 4;
>  	}

Couldn't you just use % (mod)?

-Nate