From owner-svn-src-all@FreeBSD.ORG Sun Apr 19 09:26:21 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F3B47607 for ; Sun, 19 Apr 2015 09:26:20 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4C88FA3 for ; Sun, 19 Apr 2015 09:26:20 +0000 (UTC) Received: by wgyo15 with SMTP id o15so151173669wgy.2 for ; Sun, 19 Apr 2015 02:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ZEQdzeYbzcVAZHqsKehVMX75qdADsPG2QfWtzOoxAco=; b=EMaNXgeHlXUlxm+Lk3B8B1PQzWO9S4U6aFF7uu3C1qlLfmWg/Afr2ckvEmGQ7ACcaL risqqLO+bIL225bavNgSEl+X5LyuEoEJ7uZb4F6NFOq0TU7ADgy0rmE70BAxS1IrXpAb PwF+01jW+B3wKGZjmR9vtiLX2AkdBIWg1k7aU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=ZEQdzeYbzcVAZHqsKehVMX75qdADsPG2QfWtzOoxAco=; b=BLveZHGQF/MWaZmqtnM/ocINstEBLZWmHL4BMvn2LuZHEQlPTRx4dhS99AlfuAMAA/ j7ikcxTri6HtxRUy1wd6b172HHS5HjT5UW5QLg4+QvEzbQY+NuoIK9P5Tk7VtiShO0jZ NT17ZMjuklgRppBXTrdi09s/Ev1DouyRy3RXKfVznSYGcgnHOJHgn6evhwj0rRYQfCXZ gTtSI1TkzXX/BqgCkwiOJipMhnhtCZXFkCZc3ayM8LVjqwZUuXYIOh9zf+9vKBlfqVBs O5PruqnHAmMfC5lMadkoqJmpx9Pz/bBrF4yfgcwEX4en5DZeFims/C09TUFTK4j6EPZQ 7r9g== X-Gm-Message-State: ALoCoQkRScX11RXS3l5nBd204GcfFkFuWPylFV5KKZJ8uGmFJosdAljqkdB16rpV/GvFS5p7zSaR X-Received: by 10.180.77.170 with SMTP id t10mr15680939wiw.5.1429435579043; Sun, 19 Apr 2015 02:26:19 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.28.211.135 with HTTP; Sun, 19 Apr 2015 02:25:48 -0700 (PDT) In-Reply-To: References: <201504190907.t3J97wiZ063971@svn.freebsd.org> From: Eitan Adler Date: Sun, 19 Apr 2015 02:25:48 -0700 X-Google-Sender-Auth: cON8RTfV3YpPY2sHTb4Fy4FprIg Message-ID: Subject: Re: svn commit: r281734 - head/usr.sbin/inetd To: Sergey Kandaurov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 09:26:21 -0000 On 19 April 2015 at 02:17, Sergey Kandaurov wrote: > On 19 April 2015 at 12:07, Eitan Adler wrote: >> Author: eadler >> Date: Sun Apr 19 09:07:57 2015 >> New Revision: 281734 >> URL: https://svnweb.freebsd.org/changeset/base/281734 >> >> Log: >> identd: remove redundant zeroing >> se_rpc_lowvers was set to 0 twice, so remove one of them >> I can not find any other variable which they may have been a typo of. >> >> Reported by: gcc5.1 >> >> Modified: >> head/usr.sbin/inetd/inetd.c >> >> Modified: head/usr.sbin/inetd/inetd.c >> ============================================================================== >> --- head/usr.sbin/inetd/inetd.c Sun Apr 19 08:45:37 2015 (r281733) >> +++ head/usr.sbin/inetd/inetd.c Sun Apr 19 09:07:57 2015 (r281734) >> @@ -1752,8 +1752,7 @@ more: >> memmove(sep->se_proto, sep->se_proto + 4, >> strlen(sep->se_proto) + 1 - 4); >> sep->se_rpc = 1; >> - sep->se_rpc_prog = sep->se_rpc_lowvers = >> - sep->se_rpc_lowvers = 0; >> + sep->se_rpc_prog = sep->se_rpc_lowvers = 0; >> memcpy(&sep->se_ctrladdr4, bind_sa4, >> sizeof(sep->se_ctrladdr4)); >> if ((versp = strrchr(sep->se_service, '/'))) { >> > > se_rpc_highvers ? > They both seem to be used prezeroed in a later sscanf(). hmmm, likely. I was looking for a different variable, not a different member :\ I'll fix -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams