From owner-freebsd-current@FreeBSD.ORG Tue Aug 3 11:35:18 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1DBF16A4CE for ; Tue, 3 Aug 2004 11:35:18 +0000 (GMT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FDB143D53 for ; Tue, 3 Aug 2004 11:35:18 +0000 (GMT) (envelope-from sos@DeepCore.dk) Received: from DeepCore.dk ([192.168.0.130]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i73BZ7G5062438; Tue, 3 Aug 2004 13:35:12 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <410F786B.1060206@DeepCore.dk> Date: Tue, 03 Aug 2004 13:35:07 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.5 (X11/20040329) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ville-Pertti Keinonen References: <410E688D.7020709@will.iki.fi> <410E74F7.1070000@will.iki.fi> <20040802132802.3d7kgoow0c80ss0s@www.sweetdreamsracing.biz> <410E7B8B.3080407@will.iki.fi> <410E81B8.1000206@DeepCore.dk> <410E8594.7070600@will.iki.fi> <410EA92C.6090506@DeepCore.dk> <410F3DD0.5030104@will.iki.fi> <410F4F66.8040201@DeepCore.dk> <410F5A99.8070005@will.iki.fi> <410F5D2D.4080305@DeepCore.dk> <410F695F.2060907@will.iki.fi> In-Reply-To: <410F695F.2060907@will.iki.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: freebsd-current@freebsd.org Subject: Re: ATA driver races with interrupts X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2004 11:35:18 -0000 Ville-Pertti Keinonen wrote: > Søren Schmidt wrote: > >> Reliable solutions needs reliable HW, we can narrow down the race >> window here, but without HW support we cannot close it completely >> unless we serialises access to the channels (what lots of OS's does >> btw).. > > For now, I moved my SATA disks to the Promise controller, which seems to > work with an unpatched -current. Yeah, Promise makes HW thats designed to work ;) > If serialization is the only reliable solution, shouldn't it be enabled > for all controllers with multiple channels on the same irq that use > ata_generic_intr? It isn't going to hurt performance when only using > one channel, and when using multiple channels...currently it's pretty > much guaranteed to blow up. Well, until very recently such controllers didn't exist. I've fixed the Intel SATA part, but I have no docs for the VIA SATA part so I have nothing to go by there so maybe I should mark that one as broken and serialize the accesses... -- -Søren