From owner-freebsd-ports@FreeBSD.ORG  Thu Apr 17 09:56:07 2014
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9493B9D0;
 Thu, 17 Apr 2014 09:56:07 +0000 (UTC)
Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2968514EA;
 Thu, 17 Apr 2014 09:56:06 +0000 (UTC)
Received: from home.opsec.eu (localhost [127.0.0.1])
 by home.opsec.eu (8.14.7/8.14.7) with ESMTP id s3H9tiCb063188;
 Thu, 17 Apr 2014 11:55:59 +0200 (CEST) (envelope-from lists@opsec.eu)
Received: (from pi@localhost)
 by home.opsec.eu (8.14.7/8.14.7/Submit) id s3E8TuS4016014;
 Mon, 14 Apr 2014 10:29:56 +0200 (CEST) (envelope-from lists@opsec.eu)
X-Authentication-Warning: home.opsec.eu: pi set sender to lists@opsec.eu using
 -f
Date: Mon, 14 Apr 2014 10:29:56 +0200
From: Kurt Jaeger <lists@opsec.eu>
To: Benjamin Podszun <dar@darklajid.de>
Subject: Re: FreeBSD Port: security/sshguard-pf
Message-ID: <20140414082956.GB2341@home.opsec.eu>
References: <53453547.2070307@uni-bielefeld.de>
 <fe85c5ec-65aa-425d-9e58-f70f277ad491@darklajid.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe85c5ec-65aa-425d-9e58-f70f277ad491@darklajid.de>
Cc: crees@freebsd.org, freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Apr 2014 09:56:07 -0000

Hi!

> Looking at the rc script and the diff [1] the problem's easy enough: 
> ${sshguard_pidfile} is passed as parameter to -i, but isn't set in the 
> script/has no default value. Either the related line from the previous 
> revision should be revived or the substitution should change to use 
> ${pidfile}, which _is_ set.
> 
> What now? To PR or not?

PR is always a good idea. If combined with a patch that fixes the
problem, more so.

-- 
pi@opsec.eu            +49 171 3101372                         6 years to go !