From owner-svn-src-user@FreeBSD.ORG  Thu Jan  6 03:57:06 2011
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 33A65106564A;
	Thu,  6 Jan 2011 03:57:06 +0000 (UTC)
	(envelope-from nwhitehorn@freebsd.org)
Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119])
	by mx1.freebsd.org (Postfix) with ESMTP id 01F4A8FC12;
	Thu,  6 Jan 2011 03:57:05 +0000 (UTC)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id 324B358137;
	Wed,  5 Jan 2011 21:57:05 -0600 (CST)
X-Virus-Scanned: amavisd-new at icecube.wisc.edu
Received: from mail.icecube.wisc.edu ([127.0.0.1])
	by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new,
	port 10030)
	with ESMTP id e7YsOBaVBJuX; Wed,  5 Jan 2011 21:57:05 -0600 (CST)
Received: from comporellon.tachypleus.net (unknown [76.210.75.5])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id A88DA58133;
	Wed,  5 Jan 2011 21:57:04 -0600 (CST)
Message-ID: <4D253D8F.6080408@freebsd.org>
Date: Wed, 05 Jan 2011 21:57:03 -0600
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.13) Gecko/20101214 Thunderbird/3.1.7
MIME-Version: 1.0
To: Nathan Whitehorn <nwhitehorn@FreeBSD.org>
References: <201101060356.p063u1hN001113@svn.freebsd.org>
In-Reply-To: <201101060356.p063u1hN001113@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: Re: svn commit: r217041 - user/nwhitehorn/bsdinstall/partedit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jan 2011 03:57:06 -0000

On 01/05/11 21:56, Nathan Whitehorn wrote:
> Author: nwhitehorn
> Date: Thu Jan  6 03:56:01 2011
> New Revision: 217041
> URL: http://svn.freebsd.org/changeset/base/217041
>
> Log:
>    Use the newly-available "modified" attribute in gpart to determine if we
>    have to do anything. This avoids an unnecessary warning due to an EPERM
>    trying to commit/undo changes on an unmodified geom.

This was the wrong commit message. It should have been:
Revert changes to all modified gparts if the user elects not to save 
changes.
-Nathan

> Modified:
>    user/nwhitehorn/bsdinstall/partedit/partedit.c
>
> Modified: user/nwhitehorn/bsdinstall/partedit/partedit.c
> ==============================================================================
> --- user/nwhitehorn/bsdinstall/partedit/partedit.c	Thu Jan  6 03:36:04 2011	(r217040)
> +++ user/nwhitehorn/bsdinstall/partedit/partedit.c	Thu Jan  6 03:56:01 2011	(r217041)
> @@ -99,6 +99,7 @@ main(void) {
>   				error = apply_changes(&mesh);
>   				break;
>   			} else if (op == 3) { /* Don't save =>  Quit */
> +				gpart_revert_all(&mesh);
>   				error =	-1;
>   				break;
>   			}