From owner-cvs-all@FreeBSD.ORG Thu Nov 15 22:52:03 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2422416A418; Thu, 15 Nov 2007 22:52:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 8364013C447; Thu, 15 Nov 2007 22:52:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 219545198-1834499 for multiple; Thu, 15 Nov 2007 17:52:40 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lAFMpgAl085962; Thu, 15 Nov 2007 17:51:42 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kris Kennaway Date: Thu, 15 Nov 2007 17:50:26 -0500 User-Agent: KMail/1.9.6 References: <200711152200.lAFM0xCF018460@repoman.freebsd.org> <200711151708.23974.jhb@freebsd.org> <473CC907.3070007@FreeBSD.org> In-Reply-To: <473CC907.3070007@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711151750.27613.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 15 Nov 2007 17:51:42 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/4806/Thu Nov 15 14:47:22 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 db_trace.c exception.S machdep.c trap.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2007 22:52:03 -0000 On Thursday 15 November 2007 05:32:39 pm Kris Kennaway wrote: > John Baldwin wrote: > > On Thursday 15 November 2007 05:00:57 pm John Baldwin wrote: > >> jhb 2007-11-15 22:00:57 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/amd64/amd64 db_trace.c exception.S machdep.c trap.c > >> Log: > >> Add support for cross double fault frames in stack traces: > >> - Populate the register values for the trapframe put on the stack by the > >> double fault handler. > >> - Teach DDB's trace routine to treat a double fault like other trap > > frames. > >> > >> MFC after: 3 days > > > > As an aside, because amd64 uses much saner stack frames than i386, kgdb will > > trace across a double fault just fine w/o any further patches if the kernel > > has this fix. > > > > Nice. I'm working on fixing kgdb on i386 to cross double faults as well. It's a good bit nastier as I have to do evil things to find the tss for the CPU and read the registers out of that, but I hope to test it tomorrow. -- John Baldwin