From owner-freebsd-multimedia@FreeBSD.ORG Fri Apr 24 15:30:09 2009 Return-Path: Delivered-To: freebsd-multimedia@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 725201065678 for ; Fri, 24 Apr 2009 15:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 455BA8FC2F for ; Fri, 24 Apr 2009 15:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3OFU8nI008966 for ; Fri, 24 Apr 2009 15:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3OFU8Sc008963; Fri, 24 Apr 2009 15:30:08 GMT (envelope-from gnats) Date: Fri, 24 Apr 2009 15:30:08 GMT Message-Id: <200904241530.n3OFU8Sc008963@freefall.freebsd.org> To: freebsd-multimedia@FreeBSD.org From: Eygene Ryabinkin Cc: Subject: Re: ports/132407: [patch] multimedia/ffmpeg: respect TMPDIR passed from make.conf X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eygene Ryabinkin List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2009 15:30:09 -0000 The following reply was made to PR ports/132407; it has been noted by GNATS. From: Eygene Ryabinkin To: Pav Lucistnik Cc: ahze@FreeBSD.org, marcus@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: ports/132407: [patch] multimedia/ffmpeg: respect TMPDIR passed from make.conf Date: Fri, 24 Apr 2009 19:23:24 +0400 Pav, good day. Fri, Apr 24, 2009 at 09:08:47AM +0200, Pav Lucistnik wrote: > This is not a good patch. All ./configure using ports have the same > issue. I don't see why we should address this is ffmpeg port. > Either you fix this generally in bsd.port.mk (and I see bsd.kde.mk > already have the proposed fix), or you should put > CONFIGURE_ENV=3D"TMPDIR=3D/var/tmp" to your /etc/make.conf instead. I think that I'll better fix bsd.port.mk: the new patch is below. bsd.kde.mk passed TMPDIR down only for package building, but I think that my modification should pass it always. Thanks for suggestions! --- bsd.port.mk-pass-TMPDIR.diff begins here --- =46rom d12eb79d31daea3ea9e16bd932b9de333a0cf63f Mon Sep 17 00:00:00 2001 =46rom: Eygene Ryabinkin Date: Fri, 24 Apr 2009 19:17:35 +0400 Subject: [PATCH] bsd.port.mk: pass TMPDIR from /etc/make.conf down to the t= ools Sometimes ports want to put executables to the $TMPDIR (/tmp by-default) during configure/build stages. Such ports will be broken when /tmp is mounted with 'noexec' flag. This patch addresses this problem and allows automated port builds (e.g. via portupgrade) with TMPDIR set from /etc/make.conf. Signed-off-by: Eygene Ryabinkin --- Mk/bsd.port.mk | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk index 324ed4a..647ac62 100644 --- a/Mk/bsd.port.mk +++ b/Mk/bsd.port.mk @@ -1292,6 +1292,13 @@ WITHOUT_${W}:=3D true =20 DOS2UNIX_REGEX?=3D .* =20 +# Respect TMPDIR passed via make.conf or similar and pass it down +# to configure and make. +.ifdef TMPDIR +MAKE_ENV+=3D TMPDIR=3D"${TMPDIR}" +CONFIGURE_ENV+=3D TMPDIR=3D"${TMPDIR}" +.endif # TMPDIR + =20 # Start of pre-makefile section. .if !defined(AFTERPORTMK) && !defined(INOPTIONSMK) --=20 1.6.2.4 --- bsd.port.mk-pass-TMPDIR.diff ends here --- --=20 Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ #