From owner-freebsd-current@FreeBSD.ORG Fri Dec 7 07:54:05 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94B8916A419; Fri, 7 Dec 2007 07:54:05 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from smtp8.yandex.ru (smtp8.yandex.ru [213.180.200.213]) by mx1.freebsd.org (Postfix) with ESMTP id 8A74213C459; Fri, 7 Dec 2007 07:54:04 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mail.kirov.so-cdu.ru ([77.72.136.145]:46030 "EHLO [127.0.0.1]" smtp-auth: "bu7cher" TLS-CIPHER: "DHE-RSA-AES256-SHA keybits 256/256 version TLSv1/SSLv3" TLS-PEER-CN1: ) by mail.yandex.ru with ESMTP id S7457175AbXLGHyA (ORCPT + 1 other); Fri, 7 Dec 2007 10:54:00 +0300 X-Comment: RFC 2476 MSA function at smtp8.yandex.ru logged sender identity as: bu7cher Message-ID: <4758FC14.2080606@yandex.ru> Date: Fri, 07 Dec 2007 10:53:56 +0300 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Todd Wasson References: <1B3A2410-9C2A-4126-AC92-8E38B4A0D79A@duke.edu> <200712061726.lB6HQCIu023253@fire.js.berklix.net> In-Reply-To: Content-Type: multipart/mixed; boundary="------------070005080003020307050405" Cc: =?UTF-8?B?U8O4cmVuIFNjaG1pZHQ=?= , "Julian H. Stacey" , freebsd-current@freebsd.org Subject: Re: BETA4 installer doesn't attach my HDD controller; BETA3 did X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2007 07:54:05 -0000 This is a multi-part message in MIME format. --------------070005080003020307050405 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Todd Wasson wrote: >> Todd Wasson wrote: >>> I've got a Maxtor 6Y080L0 YAR41VW0 drive on a JMicron JMB368 UDMA133 >>> controller, and in the BETA4 installer the controller doesn't seem to >>> be properly attaching, which leads to the drive not being found. The >>> relevant sections from dmesg (as I'm not sure where else to look while >>> running the installer CD) are: >> >> Did you try "Safe Boot" key 3. I think this changes may create a regression: 1. the BETA3's version: ctlr->r_type2 = SYS_RES_MEMORY; ctlr->r_rid2 = PCIR_BAR(5); if ((ctlr->r_res2 = bus_alloc_resource_any(dev, ctlr->r_type2, &ctlr->r_rid2, RF_ACTIVE))){ if ((error = ata_ahci_chipinit(dev))) return error; } We have two checks here. Probably your controller doesn't allocate a memory resource for the AHCI, but it works because it skips second checks. 2. the BETA4's version: if ((error = ata_ahci_chipinit(dev))) return error; In this version driver doesn't pass it. I've already sent patch for test to your PR, but i attach it again. May be Soren can comment it? -- WBR, Andrey V. Elsukov --------------070005080003020307050405 Content-Type: text/plain; name="ata-chipset.c.diff.txt" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="ata-chipset.c.diff.txt" LS0tIHNyYy9zeXMvZGV2L2F0YS9hdGEtY2hpcHNldC5jCTIwMDctMTEtMjIgMDA6MTU6MDAu MDAwMDAwMDAwICswMzAwCisrKyBzcmMvc3lzL2Rldi9hdGEvYXRhLWNoaXBzZXQuYwkyMDA3 LTEyLTA3IDEwOjA3OjIxLjAwMDAwMDAwMCArMDMwMApAQCAtMjI0Myw3ICsyMjQzLDcgQEAg YXRhX2ptaWNyb25fY2hpcGluaXQoZGV2aWNlX3QgZGV2KQogCXJldHVybiBFTlhJTzsKIAog ICAgIC8qIGRvIHdlIGhhdmUgbXVsdGlwbGUgUENJIGZ1bmN0aW9ucyA/ICovCi0gICAgaWYg KHBjaV9yZWFkX2NvbmZpZyhkZXYsIDB4ZGYsIDEpICYgMHg0MCkgeworICAgIGlmICgocGNp X3JlYWRfY29uZmlnKGRldiwgMHhkZiwgMSkgJiAweDQwKSB8fCBjdGxyLT5jaGlwLT5jZmcx ID09IDApIHsKIAkvKiBhcmUgd2Ugb24gdGhlIEFIQ0kgcGFydCA/ICovCiAJaWYgKGF0YV9h aGNpX2NoaXBpbml0KGRldikgIT0gRU5YSU8pCiAJICAgIHJldHVybiAwOwo= --------------070005080003020307050405--