From owner-freebsd-ports@FreeBSD.ORG Sun Jun 8 14:29:46 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D668137B401 for ; Sun, 8 Jun 2003 14:29:46 -0700 (PDT) Received: from thuis.piwebs.com (t-indiv5-84.athome.tue.nl [131.155.241.84]) by mx1.FreeBSD.org (Postfix) with SMTP id 1391143FE1 for ; Sun, 8 Jun 2003 14:29:44 -0700 (PDT) (envelope-from avleeuwen@piwebs.com) Received: (qmail 10782 invoked by uid 85); 8 Jun 2003 21:29:47 -0000 Received: from avleeuwen@piwebs.com by thuis.piwebs.com by uid 82 with qmail-scanner-1.15 (uvscan: v4.1.60/v4210. spamassassin: 2.x. Clear:SA:0(-4.3/5.0):. Processed in 11.07899 secs); 08 Jun 2003 21:29:47 -0000 X-Spam-Status: No, hits=-4.3 required=5.0 Received: from unknown (HELO 192.168.0.109) (192.168.0.109) by 0 with SMTP; 8 Jun 2003 21:29:36 -0000 From: Arjan van Leeuwen To: ted@NLnetLabs.nl (Ted Lindgreen), freebsd-current@freebsd.org, ports@FreeBSD.ORG, lioux@freebsd.org Date: Sun, 8 Jun 2003 23:29:31 +0200 User-Agent: KMail/1.5.2 References: <200306081306.h58D6F89005060@open.nlnetlabs.nl> In-Reply-To: <200306081306.h58D6F89005060@open.nlnetlabs.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200306082329.31546.avleeuwen@piwebs.com> Subject: Re: Re Regression: Playing QT files from mplayer stopped working in 5.1 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jun 2003 21:29:47 -0000 Indeed, a very dirty but effective fix. Thank you. I'll forward this to ports@ and lioux@, who has done all the recent updates on mplayer. Arjan On Sunday 08 June 2003 15:06, Ted Lindgreen wrote: > > Since a short time (don't know exactly when it happened) it's not > > possible anymore to play Quicktime files (.mov) with mplayer on > > 5.1-CURRENT. It has to be a change in -CURRENT, I haven't updated > > mplayer. > > I do not have the right fix, but the cause of the problem is > that in loader/win32.c at line 2077: > > 2076 if (v1 > 2) > 2077 if (!close(v1a)) > > close is called with a ridiciously large value. In previous > FreeBSD releases this appearently did not cause a fatal problem, > but since a week or so mplayer aborts on it. > > A stupid, but effective workaround is not to call close if v1 > is too large, f.i.: > > 2072 static int WINAPI expCloseHandle(long v1) > 2073 { > 2074 dbgprintf("CloseHandle(0x%x) => 1\n", v1); > 2075 /* do not close stdin,stdout and stderr */ > 2076 if (v1 > 2 && v1 < 128) > 2077 if (!close(v1)) > 2078 return 0; > 2079 return 1; > 2080 } > > Of course for the real fix one needs to delve deeper into mplayer > to find out where the large valued filedescriptor comes from. > > -- ted > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"