From owner-freebsd-current Sat Feb 19 1:19:39 2000 Delivered-To: freebsd-current@freebsd.org Received: from fgwmail7.fujitsu.co.jp (fgwmail7.fujitsu.co.jp [192.51.44.37]) by hub.freebsd.org (Postfix) with ESMTP id 2D7B237BB6B; Sat, 19 Feb 2000 01:19:30 -0800 (PST) (envelope-from shin@nd.net.fujitsu.co.jp) Received: from m5.gw.fujitsu.co.jp by fgwmail7.fujitsu.co.jp (8.9.3/3.7W-MX0002-Fujitsu Gateway) id SAA16766; Sat, 19 Feb 2000 18:18:35 +0900 (JST) (envelope-from shin@nd.net.fujitsu.co.jp) Received: from incapgw.fujitsu.co.jp by m5.gw.fujitsu.co.jp (8.9.3/3.7W-0002-Fujitsu Domain Master) id SAA04115; Sat, 19 Feb 2000 18:18:34 +0900 (JST) Received: from localhost ([192.168.245.162]) by incapgw.fujitsu.co.jp (8.9.3/3.7W-0002) id SAA25697; Sat, 19 Feb 2000 18:18:32 +0900 (JST) To: ache@FreeBSD.ORG Cc: saxonww@ufl.edu, current@FreeBSD.ORG Subject: Re: Broken FTP In-Reply-To: <20000218152417.A52305@freebsd.org> References: <20000218103132.A74763@freebsd.org> <20000219044734W.shin@nd.net.fujitsu.co.jp> <20000218152417.A52305@freebsd.org> X-Mailer: Mew version 1.94 on Emacs 20.4 / Mule 4.0 (HANANOEN) X-Prom-Mew: Prom-Mew 1.93.4 (procmail reader for Mew) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20000219181917Q.shin@nd.net.fujitsu.co.jp> Date: Sat, 19 Feb 2000 18:19:17 +0900 From: Yoshinobu Inoue X-Dispatcher: imput version 990905(IM130) Lines: 30 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > Could you please create the patch which seems to be safely > > committed? That will be very much help. > > Well, I can try but I need to know most shortest and most trivial EPSV > check sequence from you since can't check it locally and don't know about EPSV. EPSV is just enhanced version of PASV, and I think it needs to check same kind of errors. Maybe same check as getreply() in ftp/ftp.c will be necessary. About the spec, please check RFC2428. But the problem is that the error message is printed in getreply() which is called from command(), because the error message is sent from server. So following type of check won't work because when returned from command(), the error message is already printed out... > Look at util.c setpeer() function lines > > if (command("PASSERVE %s", argv[1]) != COMPLETE) { ... > > and below > > if (command("SYST") == COMPLETE && overbose) { ... > > the check must be in this style... > -- > Andrey A. Chernov > > http://nagual.pp.ru/~ache/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message