From owner-freebsd-bugs@FreeBSD.ORG  Fri Nov 12 05:10:28 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5DD7516A4D0
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 12 Nov 2004 05:10:28 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2FF5643D4C
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 12 Nov 2004 05:10:28 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iAC5AS7H088001
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 12 Nov 2004 05:10:28 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iAC5AS2n088000;
	Fri, 12 Nov 2004 05:10:28 GMT
	(envelope-from gnats)
Resent-Date: Fri, 12 Nov 2004 05:10:28 GMT
Resent-Message-Id: <200411120510.iAC5AS2n088000@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	KIYOHARA Takashi <kiyohara@kk.iij4u.or.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8674A16A4D1
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 12 Nov 2004 05:09:20 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7A5B743D31
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 12 Nov 2004 05:09:20 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id iAC59KPN051295
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Nov 2004 05:09:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id iAC59J9k051292;
	Fri, 12 Nov 2004 05:09:19 GMT
	(envelope-from nobody)
Message-Id: <200411120509.iAC59J9k051292@www.freebsd.org>
Date: Fri, 12 Nov 2004 05:09:19 GMT
From: KIYOHARA Takashi <kiyohara@kk.iij4u.or.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: kern/73852: Not htonl() but ntohl()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Nov 2004 05:10:28 -0000


>Number:         73852
>Category:       kern
>Synopsis:       Not htonl() but ntohl()
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 12 05:10:27 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     KIYOHARA Takashi
>Release:        
>Organization:
>Environment:
>Description:
see sys/net/if_fwsubr.c::firewire_input().
Why does it perform htonl() at the time of input of a packet?
An input packet is a network-byte-order. We should use ntohl().
>How-To-Repeat:
      
>Fix:
sys/net/if_fwsubr.c::firewire_input()
-------------------------------------
void
firewire_input(struct ifnet *ifp, struct mbuf *m, uint16_t src)
{

      ... snip ...

	/*
	 * Byte swap the encapsulation header manually.
	 */
-	enc->ul[0] = htonl(enc->ul[0]);
+	enc->ul[0] = ntohl(enc->ul[0]);

	if (enc->unfrag.lf != 0) {
		m = m_pullup(m, 2*sizeof(uint32_t));
		if (!m)
			return;
		enc = mtod(m, union fw_encap *);
-		enc->ul[1] = htonl(enc->ul[1]);
+		enc->ul[1] = ntohl(enc->ul[1]);
		m = firewire_input_fragment(fc, m, src);

>Release-Note:
>Audit-Trail:
>Unformatted: