From owner-freebsd-ports Mon Aug 5 17:31:16 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B23F37B40A; Mon, 5 Aug 2002 17:31:09 -0700 (PDT) Received: from squall.waterspout.com (squall.waterspout.com [208.13.56.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25538442B0; Mon, 5 Aug 2002 17:23:56 -0700 (PDT) (envelope-from will@csociety.org) Received: by squall.waterspout.com (Postfix, from userid 1050) id D14129B3A; Mon, 5 Aug 2002 18:54:41 -0500 (EST) Date: Mon, 5 Aug 2002 18:54:41 -0500 From: Will Andrews To: Eric Melville Cc: portmgr@FreeBSD.org, ports@FreeBSD.org Subject: Re: patch to allow moved pkg comments Message-ID: <20020805235441.GX10699@squall.waterspout.com> Mail-Followup-To: Eric Melville , portmgr@FreeBSD.org, ports@FreeBSD.org References: <20020805163407.A21728@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020805163407.A21728@FreeBSD.org> User-Agent: Mutt/1.3.26i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, Aug 05, 2002 at 04:34:07PM -0700, Eric Melville wrote: > I wrote a patch that allows pkg-comment to be omitted, and in that case the > comment will be taken from the first line of pkg-descr. This change is > simple, safe, entirely conditionalized on pkg-comment not existing, and can > be entirely ignored if people don't like it. On the other hand, it allows a > potentially huge number of inodes to be reclaimed. > > http://people.FreeBSD.org/~eric/ports-comment.diff > > Please let me know what you think. Thanks! Sounds like a good idea. Normally I'd say put it in the Makefile, though I suppose it'd be just as easy to replace ${COMMENT} with `head -1 pkg-descr`. Regards, -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message