From owner-freebsd-current  Sun Mar 25 22:21:11 2001
Delivered-To: freebsd-current@freebsd.org
Received: from filk.iinet.net.au (syncopation-dns.iinet.net.au [203.59.24.29])
	by hub.freebsd.org (Postfix) with SMTP id F048E37B719
	for <current@FreeBSD.ORG>; Sun, 25 Mar 2001 22:21:07 -0800 (PST)
	(envelope-from julian@elischer.org)
Received: (qmail 4185 invoked by uid 666); 26 Mar 2001 06:22:48 -0000
Received: from i079-150.nv.iinet.net.au (HELO elischer.org) (203.59.79.150)
  by mail.m.iinet.net.au with SMTP; 26 Mar 2001 06:22:48 -0000
Message-ID: <3ABEDFCB.4FDD0B47@elischer.org>
Date: Sun, 25 Mar 2001 22:20:59 -0800
From: Julian Elischer <julian@elischer.org>
X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386)
X-Accept-Language: en, hu
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: current@FreeBSD.ORG
Subject: Re: si_drv1 used already?
References: <56897.985586818@critter>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Poul-Henning Kamp wrote:
> 
> In message <3ABEC9C7.F6C759CA@elischer.org>, Julian Elischer writes:
> >
> >The vmware vmmon driver used to use si_drv1 but suddenly it appears to
> >have already been used (at least it is no-longer non-zero).
> >It would fail to open because it checks it before using it during open.
> >Changing the driver to use si_drv2 fixes the problem.
> >
> >Since drv1 is defined as 'for the use of the driver'
> >I am not sure that it is wrong for the driver to use it.
> >In fact many other drivers do use it without testing it.
> >
> >I see it's used in freedev() and make_dev_alias().
> >Is it safe for the driver to use it even if it is non-zero?
> 
> I think you need to give me a bit more details before I an answer
> meaningfully...
> 
> Are you sure that the value is not from previous use by vmmon ?

no I am not sure.. I will test further.
the sequence:
1/ failed to open
2/ unload module
3/ load newly compiled module with printfs
4/ discover si_drv1 in use
5/ unload, load new version using si_drv2
6/ succeed.

it is possible that the recompile fixed another problem
that had caused another abort, but had left si_drv1 non-zero.

I'll need to recompile and reboot to confirm.

> 
> --
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD committer       | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000-2001
---> X_.---._/  
            v

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message