From owner-svn-src-all@FreeBSD.ORG Fri Jul 2 06:48:50 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BD9D106564A; Fri, 2 Jul 2010 06:48:50 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 37D288FC19; Fri, 2 Jul 2010 06:48:48 +0000 (UTC) Received: by fxm13 with SMTP id 13so2171318fxm.13 for ; Thu, 01 Jul 2010 23:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=VTDG4uPyxmmy5qUP8yJwoZEKvTuGEbFBe8cb/8gCS4Y=; b=GSUXg+uS7X1enDiKllZTtXreqrYTPuIx1Tmv/sMxjhI/WU3JKnMH3s3L3GAug7fciT VtsjLcww6l1+4szX16Ub2O53VrTp9iFyY77HVp4alDVA6gL9aUaF19Hhy1DX87/90ZEp QW8KHhaelIgWO0Kg58AavxZlRSrOp5BAQACnA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=VD57FMkf4hHEyNjAfwMCVh2umlqdHlHfzu8hbqzE0qMQyO1xOkbi9xa/7RQm/JISd2 xMabB9MkeZsh/W2FR3s7A+s8e+GWxjTHakmURpPFbn7+jRyg4+8AvRzMCsMg4bG4gVFN 7/vIDZje0Q5LaMW2/AjprBSXUcosx8wacuRmY= Received: by 10.223.126.200 with SMTP id d8mr207018fas.101.1278053322262; Thu, 01 Jul 2010 23:48:42 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id g15sm742346faa.12.2010.07.01.23.48.40 (version=SSLv3 cipher=RC4-MD5); Thu, 01 Jul 2010 23:48:41 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C2D8BC6.8000603@FreeBSD.org> Date: Fri, 02 Jul 2010 09:48:38 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.24 (X11/20100402) MIME-Version: 1.0 To: John Baldwin References: <201007012158.o61LwkJW096565@svn.freebsd.org> <201007011822.02280.jhb@freebsd.org> In-Reply-To: <201007011822.02280.jhb@freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209638 - in head/sys: amd64/amd64 i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2010 06:48:50 -0000 John Baldwin wrote: > On Thursday 01 July 2010 05:58:46 pm Alexander Motin wrote: >> Author: mav >> Date: Thu Jul 1 21:58:46 2010 >> New Revision: 209638 >> URL: http://svn.freebsd.org/changeset/base/209638 >> >> Log: >> Make stray irq counters have format alike to other counters. Unified >> format makes string processing (for example by `systat -vm`) easier. > > As I said on the mailing lists, I actually think that the old way is a > feature. I believe bde@ also has useful input on appropriately parsing > interrupt names for systat -vmstat output. Yes, we had a long conversation with Bruce. Stray interrupts on x86 were the only case found, where some other text, unrelated to event source name, printed before "irqX". I would prefer not to have such special cases instead of trying to handle them all. With more people objecting now, despite my arguments, I'll have to obey. But I still don't think that attempts to parse unformatted string is a good idea. -- Alexander Motin