From owner-cvs-src@FreeBSD.ORG  Sat Apr 12 23:01:59 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 61DC41065673;
	Sat, 12 Apr 2008 23:01:59 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id D60808FC22;
	Sat, 12 Apr 2008 23:01:58 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.1/8.14.1/ALCHEMY.FRANKEN.DE) with ESMTP id
	m3CN1vLa065167; Sun, 13 Apr 2008 01:01:57 +0200 (CEST)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.1/8.14.1/Submit) id m3CN1v1i065166;
	Sun, 13 Apr 2008 01:01:57 +0200 (CEST) (envelope-from marius)
Date: Sun, 13 Apr 2008 01:01:57 +0200
From: Marius Strobl <marius@alchemy.franken.de>
To: =?unknown-8bit?Q?S=F8ren?= Schmidt <sos@freebsd.org>
Message-ID: <20080412230157.GC44768@alchemy.franken.de>
References: <200804121721.m3CHLNqu095189@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200804121721.m3CHLNqu095189@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Apr 2008 23:01:59 -0000

On Sat, Apr 12, 2008 at 05:21:23PM +0000, Sren Schmidt wrote:
> sos         2008-04-12 17:21:23 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/ata          ata-chipset.c ata-pci.c ata-pci.h 
>   Log:
>   Dont call hw.status recursively.
>   
>   Spotted by: Marcel Moolenaar
>   
>   Revision  Changes    Path
>   1.215     +5 -7      src/sys/dev/ata/ata-chipset.c
>   1.125     +1 -1      src/sys/dev/ata/ata-pci.c
>   1.85      +1 -0      src/sys/dev/ata/ata-pci.h

Even with these fixes in place your latest round of ata(4)
changes causes acd0 to disappear on a sparc64 machine for
me. Reverting to ata(4) sources of April 9th fixes these.
Verbose before and after dmesg output is at:
http://people.freebsd.org/~marius/v100_1.txt
http://people.freebsd.org/~marius/v100_2.txt

Btw., `atacontrol list` is broken on archs where ata2 is the
first ata(4) device (probably all except amd64 and i386) as
atacontrol(8) assumes channels from 0 to IOCATAGMAXCHANNEL
exist:
# atacontrol list
atacontrol: ioctl(IOCATADEVICES): Device not configured

Marius