From owner-cvs-all Fri Nov 10 2:33: 3 2000 Delivered-To: cvs-all@freebsd.org Received: from roaming.cacheboy.net (gate.interxion.com [194.153.74.13]) by hub.freebsd.org (Postfix) with ESMTP id 512A337B4C5; Fri, 10 Nov 2000 02:33:00 -0800 (PST) Received: (from adrian@localhost) by roaming.cacheboy.net (8.11.0/8.11.0) id eAAAPIR24725; Fri, 10 Nov 2000 11:25:18 +0100 (CET) (envelope-from adrian) Date: Fri, 10 Nov 2000 11:23:56 +0100 From: Adrian Chadd To: Bruce Evans Cc: Clive Lin , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/badsect badsect.c Message-ID: <20001110112354.A24560@roaming.cacheboy.net> References: <20001109173927.B67472@educampus.ncl.edu.tw> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: ; from bde@zeta.org.au on Thu, Nov 09, 2000 at 11:35:08PM +1100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Nov 09, 2000, Bruce Evans wrote: > On Thu, 9 Nov 2000, Clive Lin wrote: > > > Is it ok to close this PR ? bde talks too much , more than I could > > catch :( > > > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=19574 > > My point in the followup about lots of dead code still applies. badsect > used a readdir() loop instead of just statfs() because it wanted to find > the character device corresponding to the mounted-on block device and > not just the mounted-on device. This is now bogus. > Yup, I noticed this. I will look at tidying up the code as per your notes, but I wanted to get it working (and easily MFCed for 4.2) before doing a thorough tidy-up. adrian -- Adrian Chadd "Programming is like sex: One mistake and you have to support for a lifetime." -- rec.humor.funny To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message