From owner-freebsd-current@FreeBSD.ORG Tue Apr 10 20:32:11 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E763416A40B for ; Tue, 10 Apr 2007 20:32:11 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id C942A13C4DE for ; Tue, 10 Apr 2007 20:32:11 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 26008 invoked from network); 10 Apr 2007 20:13:17 -0000 Received: from ppp-71-139-28-99.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.28.99) by root.org with ESMTPA; 10 Apr 2007 20:13:17 -0000 Message-ID: <461BEFD6.2050302@root.org> Date: Tue, 10 Apr 2007 13:13:10 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (X11/20061027) MIME-Version: 1.0 To: Giorgos Keramidas References: <4608A5D9.2010902@root.org> <20070327151058.5qk9etifk880g4cc@webmail.leidinger.net> <20070327140741.GA60454@kobe.laptop> <200703271227.14308.jhb@freebsd.org> <20070406211229.GB1078@kobe.laptop> In-Reply-To: <20070406211229.GB1078@kobe.laptop> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: S?ren Schmidt , Ariff Abdullah , current@freebsd.org Subject: Re: recent commits break via 8235 ata X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2007 20:32:12 -0000 Giorgos Keramidas wrote: > On 2007-03-27 12:27, John Baldwin wrote: >> If that is the case it's because code was using >> rman_get_bus(handle|tag) on a resource that wasn't activated yet which >> wouldn't have worked before the nexus changes either. Well, the bus >> tag might have been right, but the handle for SYS_RES_MEMORY would >> have been wrong. > > This is the change which stops snd_hda from working here: > > % Date: Wed, 21 Mar 2007 15:39:12 +0000 (UTC) > % Message-Id: <200703211539.l2LFdCQW036704@repoman.freebsd.org> > % From: John Baldwin > % Subject: cvs commit: src/sys/dev/acpica acpi.c > % To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org > % Cc: > % > % jhb 2007-03-21 15:39:12 UTC > % > % FreeBSD src repository > % > % Modified files: > % sys/dev/acpica acpi.c > % Log: > % Change acpi's handling of suballocating system resources to be a little > % simpler. It now can just use rman_is_region_manager() during > % acpi_release_resource() to see if the the resource is suballocated from > % a system resource. Also, the driver no longer needs MD knowledge about > % how to setup bus space tags and handles when doing a suballocation, but > % can simply rely on bus_activate_resource() in the parent setting all that > % up. > % > % Revision Changes Path > % 1.233 +39 -55 src/sys/dev/acpica/acpi.c > > If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000 > (including the sys/modules/padlock/Makefile commit of Sam Leffler, to > fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see > that the snd_hda driver probes my sound card correctly. > > Updating after the commit shown above, breaks snd_hda. I just finished a binsearch and can verify this exact commit causes the problem for my ATA also. I'll spend some more time debugging it later. John, can I back out rev 1.233 of acpi.c until you return since it prevents some machines from booting? -- Nate