From owner-freebsd-current@FreeBSD.ORG Sat Mar 9 14:51:07 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id F1B7757B for ; Sat, 9 Mar 2013 14:51:07 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by mx1.freebsd.org (Postfix) with ESMTP id B612E70B for ; Sat, 9 Mar 2013 14:51:07 +0000 (UTC) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.80.1) with esmtp (envelope-from ) id <1UEL74-001Vq2-Dt>; Sat, 09 Mar 2013 15:51:06 +0100 Received: from e178025158.adsl.alicedsl.de ([85.178.25.158] helo=munin.geoinf.fu-berlin.de) by inpost2.zedat.fu-berlin.de (Exim 4.80.1) with esmtpsa (envelope-from ) id <1UEL74-003LJ6-Ah>; Sat, 09 Mar 2013 15:51:06 +0100 Message-ID: <513B4C9A.8070602@zedat.fu-berlin.de> Date: Sat, 09 Mar 2013 15:52:10 +0100 From: "Hartmann, O." Organization: FU Berlin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130309 Thunderbird/17.0.4 MIME-Version: 1.0 To: hiren panchasara Subject: Re: pw is broken? References: <1362807830.29167.YahooMailClassic@web31805.mail.mud.yahoo.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: 85.178.25.158 Cc: ktsin@acm.org, freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Mar 2013 14:51:08 -0000 Am 03/09/13 15:34, schrieb hiren panchasara: > On Mar 8, 2013 9:44 PM, "KT Sin" wrote: >> >> pw is crashing with seg fault due to this change? >> >> > http://svnweb.freebsd.org/base/head/lib/libutil/gr_util.c?r1=245390&r2=247919 > > I think the correct fix is committed with: > http://svnweb.freebsd.org/changeset/base/248102 > > Hiren >> >> # gdb ./pw >> GNU gdb 6.1.1 [FreeBSD] >> Copyright 2004 Free Software Foundation, Inc. >> GDB is free software, covered by the GNU General Public License, and you > are >> welcome to change it and/or distribute copies of it under certain > conditions. >> Type "show copying" to see the conditions. >> There is absolutely no warranty for GDB. Type "show warranty" for > details. >> This GDB was configured as "amd64-marcel-freebsd"... >> (gdb) run groupadd test123 -g 12345 >> Starting program: /usr/src/usr.sbin/pw/pw groupadd test123 -g 12345 >> >> Program received signal SIGSEGV, Segmentation fault. >> 0x0000000080d84a4f in stpcpy () from /lib/libc.so.7 >> (gdb) bt full >> #0 0x0000000080d84a4f in stpcpy () from /lib/libc.so.7 >> No symbol table info available. >> #1 0x0000000080a5c00a in grcopy (gr=0x612ce0, newgr=0x81409100, name=0x0, >> ndx=0) at /usr/src/lib/libutil/gr_util.c:496 >> dst = 0x8 >> i = 1090277153 >> #2 0x0000000080a5bdc6 in gr_add (gr=0x612ce0, newmember=0x0) >> at /usr/src/lib/libutil/gr_util.c:451 >> newgr = (struct group *) 0x81409100 >> len = 0 >> num_mem = 0 >> #3 0x0000000080a5bd4f in gr_dup (gr=0x612ce0) >> at /usr/src/lib/libutil/gr_util.c:434 >> No locals. >> #4 0x000000000040bad7 in gr_update (grp=0x612ce0, group=0x0) at > grupd.c:78 >> pfd = 0 >> tfd = 4244492 >> gr = (struct group *) 0x0 >> old_gr = (struct group *) 0x0 >> #5 0x000000000040ba8f in addgrent (grp=0x612ce0) at grupd.c:111 >> No locals. >> #6 0x000000000040a83d in pw_group (cnf=0x612bf0, mode=0, args=0x613e78) >> at pw_group.c:258 >> ---Type to continue, or q to quit--- >> grp = (struct group *) 0x612ce0 >> members = (char **) 0x81485d00 >> rc = 0 >> a_name = (struct carg *) 0x8144c0a0 >> a_gid = (struct carg *) 0x8144c0c0 >> arg = (struct carg *) 0x0 >> grmembers = 200 >> fakegroup = {gr_name = 0x7fffffffdcb9 "test123", >> gr_passwd = 0x40fbc9 "*", gr_gid = 12345, gr_mem = 0x81485d00} >> #7 0x00000000004037fb in main (argc=3, argv=0x7fffffffd9f0) at pw.c:230 >> which = 1 >> config = 0x0 >> cnf = (struct userconf *) 0x612bf0 >> ch = -1 >> mode = 0 >> opts = {{0x40e150 > "V:C:qn:u:c:d:e:p:g:G:mM:k:s:oL:i:w:h:H:Db:NPy:Y", >> 0x40e180 "V:C:qn:u:rY", >> 0x40e18c "V:C:qn:u:c:d:e:p:g:G:mM:l:k:s:w:L:h:H:FNPY", >> 0x40e1b7 "V:C:qn:u:FPa7", 0x40e1c5 "V:C:q", 0x40e1c5 "V:C:q", >> 0x40e1c5 "V:C:q"}, {0x40e1cb "V:C:qn:g:h:H:M:opNPY", >> 0x40e1e0 "V:C:qn:g:Y", 0x40e1eb "V:C:qn:d:g:l:h:H:FM:m:NPY", >> 0x40e205 "V:C:qn:g:FPa", 0x40e1c5 "V:C:q", 0x0, 0x0}} >> funcs = {0x405270 , 0x409b60 } >> (gdb) But neither r248102 nor r248103 compile! /usr/src/sys/net80211/ieee80211_output.c:600:23: error: unused variable 'ic' [-Werror,-Wunused-variable] struct ieee80211com *ic = ni->ni_ic;) (